Commit Graph

256 Commits

Author SHA1 Message Date
TAMARA LIPOWSKI
faacd3f25c fix: Accidentally changed wrong test's calldata 2025-01-31 12:11:24 -05:00
TAMARA LIPOWSKI
5a81ed6be5 fix: Expect decimal during encoding, add assert to test
- The util function was previously expecting a value between 0 and 100, which we felt was a weird UI.
- In integration test - make sure we spent all input tokens
2025-01-31 12:04:53 -05:00
TAMARA LIPOWSKI
ff3c7aa629 test: Split swap integration test 2025-01-31 11:34:50 -05:00
semantic-release-bot
b0b24edbd6 chore(release): 0.25.1 [skip ci]
## [0.25.1](https://github.com/propeller-heads/tycho-execution/compare/0.25.0...0.25.1) (2025-01-31)

### Bug Fixes

* Fix selector - shouldn't contain spaces ([5d6f0c1](5d6f0c1673))
* Fix token index order in strategy encoding. ([c85c353](c85c353e34))
2025-01-31 15:40:53 +00:00
dianacarvalho1
62a93a6200 Merge pull request #38 from propeller-heads/router/tnl/ENG-4052-integration-test
test: Router integration tests
2025-01-31 15:38:23 +00:00
Diana Carvalho
c85c353e34 fix: Fix token index order in strategy encoding.
The contract relies on this order!!

Remove TODOs and comments

--- don't change below this line ---
ENG-4081 Took 1 hour 12 minutes


Took 12 seconds
2025-01-31 15:34:12 +00:00
TAMARA LIPOWSKI
4d697bfebf test: Router integration test with many TODOs 2025-01-31 15:34:12 +00:00
TAMARA LIPOWSKI
b01fa4cf04 test: Change some addresses to match contract test
- Use Alice's PK to match our router test, set her as the receiver too
- Component id should be a usv2 pool
- Use our router test's router address as the test's router address
- Use our test's contract (address(this)) as the sender
2025-01-31 15:34:12 +00:00
TAMARA LIPOWSKI
5d6f0c1673 fix: Fix selector - shouldn't contain spaces
I found this because I kept hitting the fallback function, meaning the selector wasn't recognized
2025-01-31 15:34:12 +00:00
TAMARA LIPOWSKI
a9c68a4de0 test: (WIP) Router integration tests
TODO it don't pass


Took 14 seconds

Took 12 minutes
2025-01-31 15:34:12 +00:00
dianacarvalho1
07020e3f6e Merge pull request #39 from propeller-heads/encoding/dc/ENG-4084-tycho-encoder-test
test: Add test for tycho encoder
2025-01-31 15:31:43 +00:00
Diana Carvalho
b047d9762e test: Add test for tycho encoder
Rename RouterEncoder to TychoEncoder

--- don't change below this line ---
ENG-4081 Took 21 minutes
2025-01-31 12:41:37 +00:00
semantic-release-bot
d153c69b8f chore(release): 0.25.0 [skip ci]
## [0.25.0](https://github.com/propeller-heads/tycho-execution/compare/0.24.0...0.25.0) (2025-01-31)

### Features

* Add ChainId model ([089e7d2](089e7d2e0f))
* Implement SplitSwapStrategyEncoder ([feb91cc](feb91cc639))
* Remove generalisation on user approvals manager ([3a69bbf](3a69bbf603))
* Simplify router encoder ([6e8d2ed](6e8d2ede59))

### Bug Fixes

* Don't leak evm specific code to interfaces(PrivateKeySigner, Chain) ([7a8872c](7a8872cc41))
* Post merge's fixes ([a28b548](a28b54888e))
* replace all unwraps with proper error handling ([5f3d440](5f3d4406bd))
* Use abi_encode_packed in ple_encode() ([82e671d](82e671df39))
* Use max instead of min to get the min_amount_out ([575c5be](575c5bea5e))
2025-01-31 09:25:10 +00:00
dianacarvalho1
cc2526d29a Merge pull request #35 from propeller-heads/encoding/dc/ENG-4081-split-swap-strategy
feat: Implement Split Swap strategy encoder
2025-01-31 09:21:12 +00:00
TAMARA LIPOWSKI
5f3d4406bd fix: replace all unwraps with proper error handling
- Or more elegant assignments in place of the `.is_some()` and `.unwrap()` method.
2025-01-30 17:19:54 -05:00
Diana Carvalho
01d101acb5 chore: Move ple_encode to EVMStrategyEncoder
--- don't change below this line ---
ENG-4081 Took 3 minutes
2025-01-30 19:47:36 +00:00
Diana Carvalho
575c5bea5e fix: Use max instead of min to get the min_amount_out
between slippaged amount and checked amount
Save router's address as Bytes and not String

--- don't change below this line ---
ENG-4081 Took 7 minutes
2025-01-30 19:44:57 +00:00
Diana Carvalho
a28b54888e fix: Post merge's fixes
Because of the renaming, git couldn't identify the new files and handle the conflicts gracefully.
Copied implementation for ExecutorStrategyEncoder from main

Rollbacked on decision to encode the executor address and selector inside the SwapEncoders. This is only necessary for certain strategies. So it should be done at the strategy level

--- don't change below this line ---
ENG-4081 Took 35 minutes
2025-01-30 19:38:22 +00:00
Diana Carvalho
01df08deaa Merge remote-tracking branch 'origin/encoding/dc/ENG-4081-split-swap-strategy' into encoding/dc/ENG-4081-split-swap-strategy 2025-01-30 19:01:32 +00:00
TAMARA LIPOWSKI
5b86ae4ac5 docs: (split strategy test) better calldata comments
...for clarity and debugging purposes.
2025-01-30 12:45:36 -05:00
Diana Carvalho
8fd3deba70 Merge branch 'refs/heads/main' into encoding/dc/ENG-4081-split-swap-strategy
# Conflicts:
#	src/encoding/evm/router_encoder.rs
#	src/encoding/evm/strategy_encoder/encoder.rs
#	src/encoding/evm/strategy_encoder/selector.rs
#	src/encoding/strategy_encoder.rs

Took 2 minutes
2025-01-30 16:08:08 +00:00
semantic-release-bot
7fee0fd5e2 chore(release): 0.24.0 [skip ci]
## [0.24.0](https://github.com/propeller-heads/tycho-execution/compare/0.23.0...0.24.0) (2025-01-30)

### Features

* rename batchSetExecutor to setExecutors ([c653062](c653062027))
* replace setExecutor with batchSetExecutor ([ea504fa](ea504faca1))

### Bug Fixes

* rm redundant test ([24e95b1](24e95b1206))
2025-01-30 15:57:45 +00:00
Harsh Vardhan Roy
355405e138 Merge pull request #37 from propeller-heads/router/hr/ENG-4194-Batch-Set-Executor
feat: replace setExecutor with batchSetExecutor
2025-01-30 21:25:26 +05:30
Harsh Vardhan Roy
0ea7ca97ee Merge branch 'main' into router/hr/ENG-4194-Batch-Set-Executor 2025-01-30 21:23:37 +05:30
semantic-release-bot
14849b2e29 chore(release): 0.23.0 [skip ci]
## [0.23.0](https://github.com/propeller-heads/tycho-execution/compare/0.22.0...0.23.0) (2025-01-30)

### Features

* add executor encoder test ([ad70a0d](ad70a0d5a8))
* add swap test with hex for univ2 executor ([0196767](0196767eff))
* add univ2 executor test with hex ([c482e21](c482e21a5f))
* remove exact_out from USV2 ([8cb95f0](8cb95f0950))
* resolve pr comments ([1b8bf56](1b8bf56c75))
* update ExecutorEncoder interface and relevant types ([5c39651](5c396512cf))
2025-01-30 15:52:02 +00:00
Harsh Vardhan Roy
8c4e48b32a Merge branch 'main' into router/hr/ENG-4194-Batch-Set-Executor 2025-01-30 21:21:52 +05:30
Harsh Vardhan Roy
9fdf017337 Merge pull request #33 from propeller-heads/encoder/hr/ENG-4082-ExecutorEncoder
feat: update ExecutorEncoder and test module with contract
2025-01-30 21:19:43 +05:30
royvardhan
6c8226340d chore: remove console 2025-01-30 21:17:25 +05:30
royvardhan
da7b02407a chore: remove console 2025-01-30 21:17:25 +05:30
royvardhan
9c35da0760 chore: rename straight_to_pool to direct_execution 2025-01-30 21:17:25 +05:30
royvardhan
8cb95f0950 feat: remove exact_out from USV2 2025-01-30 21:17:25 +05:30
royvardhan
95d45975ad chore: encoder test naming 2025-01-30 21:17:25 +05:30
royvardhan
746733056c chore: encoder test naming 2025-01-30 21:17:25 +05:30
royvardhan
4ef9b0b82f chore: use Bytes 2025-01-30 21:17:25 +05:30
royvardhan
1b8bf56c75 feat: resolve pr comments 2025-01-30 21:17:25 +05:30
royvardhan
a50c31203b chore: foundry fmt 2025-01-30 21:17:25 +05:30
royvardhan
cfce36486a chore: add comment 2025-01-30 21:17:25 +05:30
royvardhan
0196767eff feat: add swap test with hex for univ2 executor 2025-01-30 21:17:25 +05:30
royvardhan
c482e21a5f feat: add univ2 executor test with hex 2025-01-30 21:17:25 +05:30
royvardhan
0007c4924c chore: update executor encoder tests 2025-01-30 21:17:25 +05:30
royvardhan
d2289c3765 chore: update test 2025-01-30 21:17:25 +05:30
royvardhan
ad70a0d5a8 feat: add executor encoder test 2025-01-30 21:17:25 +05:30
royvardhan
5c396512cf feat: update ExecutorEncoder interface and relevant types 2025-01-30 21:17:25 +05:30
semantic-release-bot
ee0aafbc4d chore(release): 0.22.0 [skip ci]
## [0.22.0](https://github.com/propeller-heads/tycho-execution/compare/0.21.0...0.22.0) (2025-01-30)

### Features

* fixed USV3 Verification ([96af542](96af542923))
* Implement generic callback ([fafeba9](fafeba9248))
* UniswapV3Executor and integration tests ([ca32446](ca32446a9e))
* USV3 verification ([7822c4f](7822c4f913))

### Bug Fixes

* Remove amountReceived and dataOffset from the callback verification ([63b94b5](63b94b5584))
* Remove amountReceived, dataOffset from ICallbackVerifier interface ([33ada0c](33ada0cf26))
* Remove exactOut from USV3 encoding ([d8b44f6](d8b44f623b))
2025-01-30 15:40:49 +00:00
Diana Carvalho
82e671df39 fix: Use abi_encode_packed in ple_encode()
--- don't change below this line ---
ENG-4081 Took 17 minutes
2025-01-30 15:39:07 +00:00
Tamara
318ab0ad95 Merge pull request #34 from propeller-heads/router/tnl/ENG-4034-usv3-executor
feat: UniswapV3 Executor
2025-01-30 10:36:50 -05:00
Tamara
94b214384b Merge branch 'main' into router/tnl/ENG-4034-usv3-executor 2025-01-30 10:33:18 -05:00
TAMARA LIPOWSKI
83bbabddd1 chore: rename amountOwed -> amountIn
...for consistency.

Also remove comment. We will keep exact_out to avoid future interface changes.
2025-01-30 10:33:09 -05:00
royvardhan
24e95b1206 fix: rm redundant test 2025-01-30 21:01:28 +05:30
Harsh Vardhan Roy
bd49c86d86 Update TychoRouter.t.sol
Co-authored-by: Tamara <tamara@datarevenue.com>
2025-01-30 20:53:28 +05:30