Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove extra _receiver and redundant asserts

Browse Source
This commit is contained in:
royvardhan
2025-02-11 22:58:34 +05:30
parent a555683257
commit ff3209b1c8
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
foundry/src/executors/UniswapV4Executor.sol
View File

@@ -75,9 +75,7 @@ contract UniswapV4Executor is IExecutor, V4Router {
uint8 action = uint8(bytes1(actions[0])); uint8 action = uint8(bytes1(actions[0]));
// Get receiver from params[2] for all cases // Get receiver from params[2] for all cases
(, address _receiver,) = (, receiver,) = abi.decode(params[2], (Currency, address, uint256));
abi.decode(params[2], (Currency, address, uint256));
receiver = _receiver;
if (action == uint8(Actions.SWAP_EXACT_IN_SINGLE)) { if (action == uint8(Actions.SWAP_EXACT_IN_SINGLE)) {
IV4Router.ExactInputSingleParams memory swapParams = IV4Router.ExactInputSingleParams memory swapParams =

5
foundry/test/executors/UniswapV4Executor.t.sol
View File

@@ -69,9 +69,6 @@ contract UniswapV4ExecutorTest is Test, Constants {
uint256 usdeBalanceBeforePool = USDE.balanceOf(poolManager); uint256 usdeBalanceBeforePool = USDE.balanceOf(poolManager);
uint256 usdeBalanceBeforeSwapExecutor = uint256 usdeBalanceBeforeSwapExecutor =
USDE.balanceOf(address(uniswapV4Exposed)); USDE.balanceOf(address(uniswapV4Exposed));
assertEq(usdeBalanceBeforeSwapExecutor, amountIn);
uint256 usdtBalanceBeforeSwapBob = USDT.balanceOf(address(BOB));
assertEq(usdtBalanceBeforeSwapBob, 0);
bytes memory data = _encodeExactInputSingle( bytes memory data = _encodeExactInputSingle(
USDE_ADDR, USDT_ADDR, 100, BOB, true, 1, uint128(amountIn) USDE_ADDR, USDT_ADDR, 100, BOB, true, 1, uint128(amountIn)
@@ -83,7 +80,7 @@ contract UniswapV4ExecutorTest is Test, Constants {
USDE.balanceOf(address(uniswapV4Exposed)), USDE.balanceOf(address(uniswapV4Exposed)),
usdeBalanceBeforeSwapExecutor - amountIn usdeBalanceBeforeSwapExecutor - amountIn
); );
assertTrue(USDT.balanceOf(BOB) == amountOut && amountOut > 0); assertTrue(USDT.balanceOf(BOB) == amountOut);
} }
function _encodeExactInputSingle( function _encodeExactInputSingle(