From ff3209b1c861c015568c3daa691f74d95ef0c978 Mon Sep 17 00:00:00 2001 From: royvardhan Date: Tue, 11 Feb 2025 22:58:34 +0530 Subject: [PATCH] fix: remove extra _receiver and redundant asserts --- foundry/src/executors/UniswapV4Executor.sol | 4 +--- foundry/test/executors/UniswapV4Executor.t.sol | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/foundry/src/executors/UniswapV4Executor.sol b/foundry/src/executors/UniswapV4Executor.sol index 8da2a8b..f72b0d9 100644 --- a/foundry/src/executors/UniswapV4Executor.sol +++ b/foundry/src/executors/UniswapV4Executor.sol @@ -75,9 +75,7 @@ contract UniswapV4Executor is IExecutor, V4Router { uint8 action = uint8(bytes1(actions[0])); // Get receiver from params[2] for all cases - (, address _receiver,) = - abi.decode(params[2], (Currency, address, uint256)); - receiver = _receiver; + (, receiver,) = abi.decode(params[2], (Currency, address, uint256)); if (action == uint8(Actions.SWAP_EXACT_IN_SINGLE)) { IV4Router.ExactInputSingleParams memory swapParams = diff --git a/foundry/test/executors/UniswapV4Executor.t.sol b/foundry/test/executors/UniswapV4Executor.t.sol index 45178df..249c78d 100644 --- a/foundry/test/executors/UniswapV4Executor.t.sol +++ b/foundry/test/executors/UniswapV4Executor.t.sol @@ -69,9 +69,6 @@ contract UniswapV4ExecutorTest is Test, Constants { uint256 usdeBalanceBeforePool = USDE.balanceOf(poolManager); uint256 usdeBalanceBeforeSwapExecutor = USDE.balanceOf(address(uniswapV4Exposed)); - assertEq(usdeBalanceBeforeSwapExecutor, amountIn); - uint256 usdtBalanceBeforeSwapBob = USDT.balanceOf(address(BOB)); - assertEq(usdtBalanceBeforeSwapBob, 0); bytes memory data = _encodeExactInputSingle( USDE_ADDR, USDT_ADDR, 100, BOB, true, 1, uint128(amountIn) @@ -83,7 +80,7 @@ contract UniswapV4ExecutorTest is Test, Constants { USDE.balanceOf(address(uniswapV4Exposed)), usdeBalanceBeforeSwapExecutor - amountIn ); - assertTrue(USDT.balanceOf(BOB) == amountOut && amountOut > 0); + assertTrue(USDT.balanceOf(BOB) == amountOut); } function _encodeExactInputSingle(