Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: disable slither warnings

Browse Source 
- locked-ether: We do have a withdraw method. Not sure why it doesn't register with slither. Already tried renaming.
- low-level-calls: This low level call is integral to the design of our filler contract.=
This commit is contained in:
TAMARA LIPOWSKI
2025-07-08 12:23:42 -04:00
parent a114dfc9da
commit a2d123a263
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
foundry/src/uniswap_x/UniswapXFiller.sol
View File

@@ -60,6 +60,8 @@ contract UniswapXFiller is AccessControl, IReactorCallback {
// TODO properly handle native in and out tokens // TODO properly handle native in and out tokens
uint256 ethValue = 0; uint256 ethValue = 0;
// slither-disable-next-line low-level-calls
(bool success, bytes memory result) = (bool success, bytes memory result) =
tychoRouter.call{value: ethValue}(callbackData); tychoRouter.call{value: ethValue}(callbackData);
@@ -129,6 +131,7 @@ contract UniswapXFiller is AccessControl, IReactorCallback {
/** /**
* @dev Allows this contract to receive native token with empty msg.data from contracts * @dev Allows this contract to receive native token with empty msg.data from contracts
*/ */
// slither-disable-next-line locked-ether
receive() external payable { receive() external payable {
require(msg.sender.code.length != 0); require(msg.sender.code.length != 0);
} }

2
foundry/test/uniswap_x/UniswapXFiller.t.sol
View File

@@ -26,7 +26,6 @@ contract UniswapXFillerTest is Test, TychoRouterTestSetup {
filler = new UniswapXFiller(tychoRouterAddr, REACTOR); filler = new UniswapXFiller(tychoRouterAddr, REACTOR);
fillerAddr = address(filler); fillerAddr = address(filler);
filler.grantRole(keccak256("EXECUTOR_ROLE"), EXECUTOR); filler.grantRole(keccak256("EXECUTOR_ROLE"), EXECUTOR);
filler.grantRole(keccak256("REACTOR_ROLE"), REACTOR);
vm.stopPrank(); vm.stopPrank();
} }
@@ -112,7 +111,6 @@ contract UniswapXFillerTest is Test, TychoRouterTestSetup {
assertGe(IERC20(DAI_ADDR).balanceOf(BOB), amountOut); assertGe(IERC20(DAI_ADDR).balanceOf(BOB), amountOut);
} }
function testExecuteIntegration() public { function testExecuteIntegration() public {
fillerSetup(); fillerSetup();
// tx: 0x5b602b7d0a37e241bd032a907b9ddf314e9f2fc2104fd91cb55bdb3d8dfe4e9c // tx: 0x5b602b7d0a37e241bd032a907b9ddf314e9f2fc2104fd91cb55bdb3d8dfe4e9c