diff --git a/foundry/src/uniswap_x/UniswapXFiller.sol b/foundry/src/uniswap_x/UniswapXFiller.sol index bb5d0dc..1156c31 100644 --- a/foundry/src/uniswap_x/UniswapXFiller.sol +++ b/foundry/src/uniswap_x/UniswapXFiller.sol @@ -60,6 +60,8 @@ contract UniswapXFiller is AccessControl, IReactorCallback { // TODO properly handle native in and out tokens uint256 ethValue = 0; + + // slither-disable-next-line low-level-calls (bool success, bytes memory result) = tychoRouter.call{value: ethValue}(callbackData); @@ -129,6 +131,7 @@ contract UniswapXFiller is AccessControl, IReactorCallback { /** * @dev Allows this contract to receive native token with empty msg.data from contracts */ + // slither-disable-next-line locked-ether receive() external payable { require(msg.sender.code.length != 0); } diff --git a/foundry/test/uniswap_x/UniswapXFiller.t.sol b/foundry/test/uniswap_x/UniswapXFiller.t.sol index 6e3bbbb..8102e4f 100644 --- a/foundry/test/uniswap_x/UniswapXFiller.t.sol +++ b/foundry/test/uniswap_x/UniswapXFiller.t.sol @@ -26,7 +26,6 @@ contract UniswapXFillerTest is Test, TychoRouterTestSetup { filler = new UniswapXFiller(tychoRouterAddr, REACTOR); fillerAddr = address(filler); filler.grantRole(keccak256("EXECUTOR_ROLE"), EXECUTOR); - filler.grantRole(keccak256("REACTOR_ROLE"), REACTOR); vm.stopPrank(); } @@ -112,7 +111,6 @@ contract UniswapXFillerTest is Test, TychoRouterTestSetup { assertGe(IERC20(DAI_ADDR).balanceOf(BOB), amountOut); } - function testExecuteIntegration() public { fillerSetup(); // tx: 0x5b602b7d0a37e241bd032a907b9ddf314e9f2fc2104fd91cb55bdb3d8dfe4e9c