Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: inequality check for amountConsumed and amountIn

Browse Source
This commit is contained in:
royvardhan
2025-03-05 00:35:51 +05:30
parent ceef683202
commit 6f421eb374
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
foundry/src/TychoRouter.sol
View File

@@ -59,7 +59,7 @@ error TychoRouter__AddressZero();
error TychoRouter__AmountZero(); error TychoRouter__AmountZero();
error TychoRouter__EmptySwaps(); error TychoRouter__EmptySwaps();
error TychoRouter__NegativeSlippage(uint256 amount, uint256 minAmount); error TychoRouter__NegativeSlippage(uint256 amount, uint256 minAmount);
error TychoRouter__AmountInNotFullySpent(uint256 leftoverAmount); error TychoRouter__AmountInDiffersFromConsumed(uint256 amountConsumed);
error TychoRouter__MessageValueMismatch(uint256 value, uint256 amount); error TychoRouter__MessageValueMismatch(uint256 value, uint256 amount);
error TychoRouter__InvalidDataLength(); error TychoRouter__InvalidDataLength();
@@ -163,9 +163,8 @@ contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard {
uint256 amountConsumed = initialBalance - currentBalance; uint256 amountConsumed = initialBalance - currentBalance;
if (amountConsumed < amountIn) { if (amountConsumed != amountIn) {
uint256 leftoverAmount = amountIn - amountConsumed; revert TychoRouter__AmountInDiffersFromConsumed(amountConsumed);
revert TychoRouter__AmountInNotFullySpent(leftoverAmount);
} }
if (fee > 0) { if (fee > 0) {

3
foundry/test/TychoRouter.t.sol
View File

@@ -895,7 +895,8 @@ contract TychoRouterTest is TychoRouterTestSetup {
vm.expectRevert( vm.expectRevert(
abi.encodeWithSelector( abi.encodeWithSelector(
TychoRouter__AmountInNotFullySpent.selector, 400000000000000000 TychoRouter__AmountInDiffersFromConsumed.selector,
600000000000000000
) )
); );