From 6f421eb374b798e9521a2a345558fae53f77dae3 Mon Sep 17 00:00:00 2001 From: royvardhan Date: Wed, 5 Mar 2025 00:35:51 +0530 Subject: [PATCH] fix: inequality check for amountConsumed and amountIn --- foundry/src/TychoRouter.sol | 7 +++---- foundry/test/TychoRouter.t.sol | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/foundry/src/TychoRouter.sol b/foundry/src/TychoRouter.sol index d250695..8897435 100644 --- a/foundry/src/TychoRouter.sol +++ b/foundry/src/TychoRouter.sol @@ -59,7 +59,7 @@ error TychoRouter__AddressZero(); error TychoRouter__AmountZero(); error TychoRouter__EmptySwaps(); error TychoRouter__NegativeSlippage(uint256 amount, uint256 minAmount); -error TychoRouter__AmountInNotFullySpent(uint256 leftoverAmount); +error TychoRouter__AmountInDiffersFromConsumed(uint256 amountConsumed); error TychoRouter__MessageValueMismatch(uint256 value, uint256 amount); error TychoRouter__InvalidDataLength(); @@ -163,9 +163,8 @@ contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard { uint256 amountConsumed = initialBalance - currentBalance; - if (amountConsumed < amountIn) { - uint256 leftoverAmount = amountIn - amountConsumed; - revert TychoRouter__AmountInNotFullySpent(leftoverAmount); + if (amountConsumed != amountIn) { + revert TychoRouter__AmountInDiffersFromConsumed(amountConsumed); } if (fee > 0) { diff --git a/foundry/test/TychoRouter.t.sol b/foundry/test/TychoRouter.t.sol index 5c7caee..1717ddb 100644 --- a/foundry/test/TychoRouter.t.sol +++ b/foundry/test/TychoRouter.t.sol @@ -895,7 +895,8 @@ contract TychoRouterTest is TychoRouterTestSetup { vm.expectRevert( abi.encodeWithSelector( - TychoRouter__AmountInNotFullySpent.selector, 400000000000000000 + TychoRouter__AmountInDiffersFromConsumed.selector, + 600000000000000000 ) );