bugfix; web tabs

gateway/src/harness/subagents/strategy/index.ts

@@ -1,137 +1,17 @@
-import { BaseSubagent, type SubagentConfig, type SubagentContext } from '../base-subagent.js';
+import { BaseSubagent } from '../base-subagent.js';
 import type { BaseChatModel } from '@langchain/core/language_models/chat_models';
-import { SystemMessage } from '@langchain/core/messages';
-import { createReactAgent } from '@langchain/langgraph/prebuilt';
 import type { FastifyBaseLogger } from 'fastify';
 import type { MCPClientConnector } from '../../mcp-client.js';
-import type { HarnessEvent } from '../../harness-events.js';
 
 /**
  * Strategy Subagent
  *
  * Specialized agent for writing PandasStrategy classes, running backtests,
  * and managing strategy activation/deactivation.
- *
- * Mirrors the pattern of IndicatorSubagent in indicator/index.ts.
  */
 export class StrategySubagent extends BaseSubagent {
-  constructor(
-    config: SubagentConfig,
-    model: BaseChatModel,
-    logger: FastifyBaseLogger,
-    mcpClient?: MCPClientConnector,
-    tools?: any[]
-  ) {
-    super(config, model, logger, mcpClient, tools);
-  }
-
-  /**
-   * Execute a strategy request using LangGraph's createReactAgent.
-   */
-  async execute(context: SubagentContext, instruction: string): Promise<string> {
-    this.logger.info(
-      {
-        subagent: this.getName(),
-        userId: context.userContext.userId,
-        instruction: instruction.substring(0, 200),
-        toolCount: this.tools.length,
-        toolNames: this.tools.map(t => t.name),
-      },
-      'Strategy subagent starting'
-    );
-
-    if (!this.hasMCPClient()) {
-      throw new Error('MCP client not available for strategy subagent');
-    }
-
-    if (this.tools.length === 0) {
-      this.logger.warn('Strategy subagent has no tools');
-    }
-
-    const initialMessages = this.buildMessages(context, instruction);
-    const systemMessage = initialMessages[0];
-    const humanMessage = initialMessages[initialMessages.length - 1];
-
-    const agent = createReactAgent({
-      llm: this.model,
-      tools: this.tools,
-      prompt: systemMessage as SystemMessage,
-    });
-
-    const result = await agent.invoke(
-      { messages: [humanMessage] },
-      { recursionLimit: 30 }
-    );
-
-    const allMessages: any[] = result.messages ?? [];
-
-    this.logger.info(
-      { messageCount: allMessages.length },
-      'Strategy subagent graph completed'
-    );
-
-    const lastAI = [...allMessages].reverse().find(
-      (m: any) => m.constructor?.name === 'AIMessage' || m._getType?.() === 'ai'
-    );
-
-    const finalText = lastAI
-      ? (typeof lastAI.content === 'string' ? lastAI.content : JSON.stringify(lastAI.content))
-      : 'Strategy task completed.';
-
-    this.logger.info({ textLength: finalText.length }, 'Strategy subagent finished');
-
-    return finalText;
-  }
-
-  async *streamEvents(context: SubagentContext, instruction: string, signal?: AbortSignal): AsyncGenerator<HarnessEvent, string> {
-    this.logger.info({ subagent: this.getName() }, 'streamEvents starting');
-
-    if (!this.hasMCPClient()) {
-      throw new Error('MCP client not available for strategy subagent');
-    }
-
-    const initialMessages = this.buildMessages(context, instruction);
-    const systemMessage = initialMessages[0];
-    const humanMessage = initialMessages[initialMessages.length - 1];
-
-    const agent = createReactAgent({
-      llm: this.model,
-      tools: this.tools,
-      prompt: systemMessage as SystemMessage,
-    });
-
-    const stream = agent.stream(
-      { messages: [humanMessage] },
-      { streamMode: ['messages', 'updates'], recursionLimit: 30, signal }
-    );
-
-    let finalText = '';
-
-    for await (const [mode, data] of await stream) {
-      if (signal?.aborted) break;
-      if (mode === 'messages') {
-        for (const chunk of StrategySubagent.extractStreamChunks(data, this.config.name)) {
-          yield chunk;
-        }
-      } else if (mode === 'updates') {
-        if ((data as any).agent?.messages) {
-          for (const msg of (data as any).agent.messages as any[]) {
-            if (msg.tool_calls?.length) {
-              for (const tc of msg.tool_calls) {
-                yield { type: 'subagent_tool_call', agentName: this.config.name, toolName: tc.name, label: tc.name };
-              }
-            } else {
-              const content = StrategySubagent.extractFinalText(msg);
-              if (content) finalText = content;
-            }
-          }
-        }
-      }
-    }
-
-    this.logger.info({ textLength: finalText.length }, 'streamEvents finished');
-    return finalText;
-  }
+  protected getRecursionLimit() { return 30; }
+  protected getFallbackText() { return 'Strategy task completed.'; }
 }
 
 /**
@@ -144,16 +24,8 @@ export async function createStrategySubagent(
   mcpClient?: MCPClientConnector,
   tools?: any[]
 ): Promise<StrategySubagent> {
-  const { readFile } = await import('fs/promises');
-  const { join } = await import('path');
-  const yaml = await import('js-yaml');
-
-  const configPath = join(basePath, 'config.yaml');
-  const configContent = await readFile(configPath, 'utf-8');
-  const config = yaml.load(configContent) as SubagentConfig;
-
+  const config = await BaseSubagent.loadConfig(basePath);
   const subagent = new StrategySubagent(config, model, logger, mcpClient, tools);
   await subagent.initialize(basePath);
-
   return subagent;
 }