Liquidity.Party/tycho-protocol-sdk
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: stop using buggy account_creations for creation tagging. (#201)

Browse Source 
the `call.account_creations` field had been deprecated by Substreams because of some edge cases where a new account wasn't detected.
This commit removes the usage of this field in our sdk contract extraction logic and some others specific places. We decided to rely on the call type instead. This approach should be much more robust.

Co-authored-by: zizou <111426680+flopell@users.noreply.github.com>
This commit is contained in:
Zizou
2025-05-13 12:25:14 +02:00
committed by GitHub
parent ee41e63775
commit 52d502198e
7 changed files with 49 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
substreams/crates/tycho-substreams/Cargo.toml
View File

@@ -1,6 +1,6 @@
[package]
name = "tycho-substreams"
version = "0.2.0"
version = "0.2.1"
edition = "2021"
description = "Tycho substreams development kit, contains tycho-indexer block changes model and helper functions for common indexing tasks."
repository = "https://github.com/propeller-heads/tycho-protocol-sdk/tree/main/substreams/crates/tycho-substreams"

17
substreams/crates/tycho-substreams/src/contract.rs
View File

@@ -8,7 +8,7 @@
/// ## Warning
/// ⚠️ These helpers *only* work if the **extended block model** is available,
/// more [here](https://streamingfastio.medium.com/new-block-model-to-accelerate-chain-integration-9f65126e5425)
use std::collections::HashMap;
use std::collections::{HashMap, HashSet};
use crate::{
models::{InterimContractChange, TransactionChanges},
@@ -97,14 +97,11 @@ fn extract_contract_changes_generic<
.transactions()
.for_each(|block_tx| {
// Collect all accounts created in this tx
let created_accounts: HashMap<_, _> = block_tx
let created_accounts: HashSet<_> = block_tx
.calls
.iter()
.flat_map(|call| {
call.account_creations
.iter()
.map(|ac| (&ac.account, ac.ordinal))
})
.filter(|call| call.call_type() == CallType::Create)
.map(|call| call.address.clone())
.collect();
let mut storage_changes = Vec::new();
@@ -140,7 +137,7 @@ fn extract_contract_changes_generic<
.or_insert_with(|| {
InterimContractChange::new(
&storage_change.address,
created_accounts.contains_key(&storage_change.address),
created_accounts.contains(&storage_change.address),
)
});
@@ -156,7 +153,7 @@ fn extract_contract_changes_generic<
.or_insert_with(|| {
InterimContractChange::new(
&balance_change.address,
created_accounts.contains_key(&balance_change.address),
created_accounts.contains(&balance_change.address),
)
});
@@ -174,7 +171,7 @@ fn extract_contract_changes_generic<
.or_insert_with(|| {
InterimContractChange::new(
&code_change.address,
created_accounts.contains_key(&code_change.address),
created_accounts.contains(&code_change.address),
)
});