From 139f7ac3f5951f1d9958a386ecd3b9f70b127f06 Mon Sep 17 00:00:00 2001 From: Florian Pellissier <111426680+flopell@users.noreply.github.com> Date: Thu, 8 Aug 2024 00:12:34 +0200 Subject: [PATCH] refactor(substreams-testing): Remove shallow functions, be more :snake: --- testing/src/runner/models.py | 7 ------- testing/src/runner/runner.py | 6 +++--- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/testing/src/runner/models.py b/testing/src/runner/models.py index aa79559..992efa5 100644 --- a/testing/src/runner/models.py +++ b/testing/src/runner/models.py @@ -50,10 +50,6 @@ class ProtocolComponentExpectation(BaseModel): return "\n".join(differences) - @staticmethod - def from_dto(dto: ProtocolComponent) -> "ProtocolComponentExpectation": - return ProtocolComponentExpectation(**dto.dict()) - class ProtocolComponentWithTestConfig(ProtocolComponentExpectation): """Represents a ProtocolComponent with its main attributes and test configuration.""" @@ -63,9 +59,6 @@ class ProtocolComponentWithTestConfig(ProtocolComponentExpectation): description="Flag indicating whether to skip simulation for this component", ) - def into_protocol_component(self) -> ProtocolComponentExpectation: - return ProtocolComponentExpectation(**self.dict()) - class IntegrationTest(BaseModel): """Configuration for an individual test.""" diff --git a/testing/src/runner/runner.py b/testing/src/runner/runner.py index c25292d..bf17ef3 100644 --- a/testing/src/runner/runner.py +++ b/testing/src/runner/runner.py @@ -137,9 +137,9 @@ class TestRunner: f"'{comp_id}' not found in protocol components." ) - diff = ProtocolComponentExpectation.from_dto( - components_by_id[comp_id] - ).compare(expected_component.into_protocol_component()) + diff = ProtocolComponentExpectation( + **components_by_id[comp_id].dict() + ).compare(ProtocolComponentExpectation(**expected_component.dict())) if diff is not None: return TestResult.Failed(diff)