Liquidity.Party/tycho-protocol-sdk
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Compare lowercase component IDs

Browse Source 
- This was failing. Make this more lenient so the user can specify component id in the test file in a non-case-sensitive manner.
- Also switched around a wrong token order which was causing a failure (not sure we care about token order but we may in the future? Python didn't care...)
This commit is contained in:
TAMARA LIPOWSKI
2025-09-17 18:20:13 -04:00
committed by Tamara
parent 779c690b6d
commit 0226bda482
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
protocol-testing/src/config.rs
View File

@@ -28,8 +28,8 @@ impl ProtocolComponentExpectation {
pub fn compare(&self, other: &ProtocolComponent, colorize_output: bool) -> Option<String> {
let mut diffs = Vec::new();
// Compare id
if self.id != other.id {
// Compare id (case-insensitive)
if self.id.to_lowercase() != other.id.to_lowercase() {
let diff = self.format_diff("id", &self.id, &other.id, colorize_output);
diffs.push(format!("Field 'id' mismatch for {}:\n{}", self.id, diff));
}

10
protocol-testing/src/test_runner.rs
View File

@@ -257,7 +257,7 @@ fn validate_state(
let expected_ids = expected_components
.iter()
.map(|c| c.base.id.clone())
.map(|c| c.base.id.to_lowercase())
.collect::<Vec<String>>();
let protocol_states = rt
@@ -274,12 +274,12 @@ fn validate_state(
let components_by_id: HashMap<String, ProtocolComponent> = protocol_components
.clone()
.into_iter()
.map(|c| (c.id.clone(), c))
.map(|c| (c.id.to_lowercase(), c))
.collect();
let protocol_states_by_id: HashMap<String, ResponseProtocolState> = protocol_states
.into_iter()
.map(|s| (s.component_id.clone(), s))
.map(|s| (s.component_id.to_lowercase(), s))
.collect();
info!("Found {} protocol components", components_by_id.len());
@@ -290,7 +290,7 @@ fn validate_state(
// Step 1: Validate that all expected components are present on Tycho after indexing
debug!("Validating {:?} expected components", expected_components.len());
for expected_component in expected_components {
let component_id = expected_component.base.id.clone();
let component_id = expected_component.base.id.to_lowercase();
let component = components_by_id
.get(&component_id)
@@ -366,7 +366,7 @@ fn validate_state(
let simulation_component_ids: std::collections::HashSet<String> = expected_components
.iter()
.filter(|c| !c.skip_simulation)
.map(|c| c.base.id.clone())
.map(|c| c.base.id.to_lowercase())
.collect();
info!("Components to simulate: {}", simulation_component_ids.len());