Commit Graph

437 Commits

Author SHA1 Message Date
royvardhan
66c00df4f1 test: add testCyclicSplitSwap test and update var naming in testCyclicSequentialSwap 2025-03-10 18:12:58 +05:30
royvardhan
57acbd58c5 fix: remove amountIn addition to amountOut in _swap for cyclic swaps, add testCyclicSwapWithTwoPools test to verify 2025-03-10 18:12:58 +05:30
TAMARA LIPOWSKI
b74d4c9e25 chore: remove unnecessary min amount check, doc fix 2025-03-06 10:37:37 -05:00
Tamara
9821ab0c00 Merge branch 'main' into router/tnl/basescan-verify 2025-03-05 13:15:37 -05:00
TAMARA LIPOWSKI
09208b342a test: Add testSwapCheckedUndefinedMinAmount
To check if the swap actually reverts when min amount is 0.
2025-03-05 13:06:06 -05:00
Diana Carvalho
5c28d77f1d feat: Check min amount out is not zero
Update tests

--- don't change below this line ---
ENG-4286 Took 57 minutes


Took 20 seconds
2025-03-05 17:53:51 +00:00
royvardhan
7833086425 fix: TychoRouter swap check test naming and docs 2025-03-05 22:23:16 +05:30
Harsh Vardhan Roy
2086484898 docs: remove unnecessary comment from swap
Co-authored-by: Tamara <tamara@datarevenue.com>
2025-03-05 22:23:16 +05:30
royvardhan
f853739a3d feat: add transferFrom in swap and move core swap logic inside _swapChecked 2025-03-05 22:23:16 +05:30
Harsh Vardhan Roy
013113c4d9 Merge branch 'main' into router/hr/ENG-4280-gas-test 2025-03-05 21:32:40 +05:30
royvardhan
a3bffd4f75 fix: add amountIn in error TychoRouter__AmountInDiffersFromConsumed 2025-03-05 00:45:22 +05:30
royvardhan
6f421eb374 fix: inequality check for amountConsumed and amountIn 2025-03-05 00:35:51 +05:30
TAMARA LIPOWSKI
bc54eac110 feat: Rename Etherscan in deployment verification
This could also be Basescan. Abstract away to blockchain explorer.
2025-03-03 17:14:39 -05:00
Diana Carvalho
db9c8cde5a fix: Make permit2 permit an action in the universal router
--- don't change below this line ---
ENG-4286 Took 1 hour 35 minutes
2025-03-03 18:33:22 +00:00
Harsh Vardhan Roy
d3e0e066fa Merge branch 'main' into router/hr/ENG-4280-gas-test 2025-03-01 00:11:34 +05:30
royvardhan
ec8d59eeae test: remove gas usage numbers from GasTest 2025-03-01 00:09:15 +05:30
royvardhan
6f69748ba4 test: update gas usage numbers in GasTest 2025-02-28 22:02:21 +05:30
royvardhan
5db95781e5 test: add isPermit2 bool in GasTest for readability 2025-02-28 10:11:04 +05:30
TAMARA LIPOWSKI
33973a65b8 fix: make USV2 factory configurable in Executor
- This factory is not the same for Ethereum and Base, so Base txs were failing when verifying pool addresses.
- I've double checked that we don't have this problem for Balancer V2 - the vault address in the same on Base and on Ethereum Mainnet.
2025-02-27 23:15:08 -05:00
royvardhan
9014fc7383 test: add permit2 tests for simple swaps in TychoRouter and GasTest 2025-02-28 00:40:56 +05:30
royvardhan
35e706d6ea test: add GasTest to compare with Universal Router gas usage 2025-02-28 00:40:56 +05:30
Diana Carvalho
fedc5043db feat: Deploy to mainnet (again)
--- don't change below this line ---
ENG-4260 Took 22 minutes
2025-02-27 18:01:15 +00:00
Diana Carvalho
59eb2195b6 feat: Change license to SPDX-License-Identifier: UNLICENSED everywhere
Remove unnecessary files

--- don't change below this line ---
ENG-4260 Took 13 minutes
2025-02-27 17:38:53 +00:00
Diana Carvalho
3d65ac8cd9 feat: Deploy to mainnet. Update all addresses
--- don't change below this line ---
ENG-4260 Took 27 minutes


Took 10 seconds
2025-02-27 17:25:54 +00:00
Diana Carvalho
79045e2689 feat: Verify contracts on etherscan
--- don't change below this line ---
ENG-4260 Took 31 minutes
2025-02-27 15:52:32 +00:00
Diana Carvalho
d011c4b475 Merge branch 'refs/heads/main' into router/dc/deploy-executors 2025-02-27 15:00:17 +00:00
royvardhan
0273f58274 fix: remove 0 amount check in _unwrapEth 2025-02-27 20:08:49 +05:30
Harsh Vardhan Roy
393ed61595 docs: update _unwrapEth docs
Co-authored-by: Tamara <tamara@datarevenue.com>
2025-02-27 20:08:49 +05:30
royvardhan
353861f738 refactor: update unwrapEth to only check 0 amount 2025-02-27 20:08:49 +05:30
Diana Carvalho
9eb4299ffe fix: the key for univ4 fee is key_lp_fee
Update tests with new executor addresses as well

--- don't change below this line ---
ENG-4260 Took 6 minutes
2025-02-27 11:49:03 +00:00
Diana Carvalho
f95c74fbc6 feat: Deploy all executors
univ3, univ4 and balancer v2

--- don't change below this line ---
ENG-4260 Took 33 minutes
2025-02-27 09:44:53 +00:00
Tamara
503d7e0907 Merge branch 'main' into router/tnl/ENG-4269-base-deployment 2025-02-26 13:21:04 -05:00
TAMARA LIPOWSKI
ac35256c69 fix: rename mainnet -> ethereum
we must match what we have in the executors file (which is what tycho-indexer gives us)
2025-02-26 13:20:51 -05:00
TAMARA LIPOWSKI
e5759b9498 fix: TENDERLY_RPC_URL -> RPC_URL
for simplicity and consistency
2025-02-26 13:01:48 -05:00
royvardhan
7b0dd5872c chore: merge main 2025-02-26 23:26:27 +05:30
TAMARA LIPOWSKI
adfcb3da82 fix: proper executor address json after merge 2025-02-26 12:39:54 -05:00
TAMARA LIPOWSKI
1bdcbb83e0 fix: (deployment) add tenderly keys to json files 2025-02-26 10:59:35 -05:00
TAMARA LIPOWSKI
7ca9120b7b feat: support base deployment
gas limit had to be set when setting executors on base: kept getting UNPREDICTABLE_GAS_LIMIT error. It should definitely not cost more than 100000 gas to set limit... but this may be a problem on other chains in the future.
2025-02-26 10:59:25 -05:00
royvardhan
0be69c9aea refactor: check if amountIn was fully consumed based on balance changes 2025-02-26 19:04:26 +05:30
royvardhan
53d48f1bac refactor: centralize swap logic to reduce duplication between swap and swapPermit2 2025-02-26 18:05:29 +05:30
Diana Carvalho
57789a40e4 fix: Unify both executor addresses in one file
- Move executor_addresses.json to a top level directory
- Delete executors.json
- Use the same file for both encoding and setting executors

--- don't change below this line ---
ENG-4260 Took 19 minutes


Took 11 seconds
2025-02-26 10:10:30 +00:00
Diana Carvalho
34563c3eb7 feat: Deploy on mainnet
Also update executors.json with uniswap v2 address on mainnet

--- don't change below this line ---
ENG-4101 Took 22 minutes


Took 7 seconds
2025-02-26 09:49:00 +00:00
Diana Carvalho
02a9da183e feat: Deploy executors and set them in router
--- don't change below this line ---
ENG-4101 Took 59 minutes


Took 10 seconds
2025-02-26 09:49:00 +00:00
Diana Carvalho
90cf194869 feat: Set roles script
Added a roles.json file where we can define all the addresses that need roles

--- don't change below this line ---
ENG-4101 Took 42 seconds
2025-02-26 09:49:00 +00:00
Diana Carvalho
77ba9498a7 feat: Verify router contract on tenderly
Fix package.json

--- don't change below this line ---
ENG-4101 Took 34 minutes
2025-02-26 09:49:00 +00:00
Diana Carvalho
cbea0bdab3 feat: Add deployment and fund wallet scripts
--- don't change below this line ---
ENG-4101 Took 1 hour 2 minutes


Took 2 minutes

Took 8 minutes

Took 4 minutes

Took 28 minutes
2025-02-26 09:49:00 +00:00
dianacarvalho1
6008d5e836 Merge branch 'main' into router/dc/ENG-4260-improve-receive 2025-02-26 09:40:58 +00:00
TAMARA LIPOWSKI
857522134b chore: forge fmt
kill blank lines
2025-02-25 13:14:30 -05:00
TAMARA LIPOWSKI
abef1e062e style: TychoRouter ascii art 2025-02-25 13:10:29 -05:00
Diana Carvalho
801976fafa fix: Restrict receive callers to have code
--- don't change below this line ---
ENG-4260 Took 8 minutes
2025-02-25 09:36:04 +00:00