Tamara
f029cd5baf
Merge branch 'main' into encoding/tnl/ENG-4071-usv4
2025-02-17 23:57:21 -05:00
TAMARA LIPOWSKI
8f1e372c90
refactor: PR comments (moving things around/docs)...
...
- Move the validator into its own file, for organization purposes.
- Add missing elements to `SplitSwapStrategyEncoder` docstring
2025-02-17 23:57:01 -05:00
TAMARA LIPOWSKI
44aabf1761
feat: Merge USV4 strategy back into split strategy
...
- Since the group_swaps method is now generalized, there is no need to have an entirely separate method here.
2025-02-17 23:44:58 -05:00
TAMARA LIPOWSKI
47b61802ee
feat: Generalize group_swaps method
...
- This can now be used for any groupable protocols - not just USV4.
2025-02-17 17:23:29 -05:00
TAMARA LIPOWSKI
957bf898f2
fix: Do not group split swaps
...
As far as we know, Uniswap V4 has no support for optimizing split swaps - only sequential swaps. We must make sure we don't accidentally group split swaps too - as this will likely revert due to mismatched input and output values.
2025-02-17 16:50:59 -05:00
TAMARA LIPOWSKI
e94154bc2d
fix: Do not count intermediary tokens in indices
...
To achieve this, a small refactor was necessary with the introduction of a SwapGroup object, and a separate method to create a vec of these objects. This then separates all logic related to combining protocol data nicely and cleanly into its own method with its own tests.
TODO:
- Deal with split swaps and add test for split swap scenario
- Clean up all existing PR comments
2025-02-14 18:48:39 -05:00
semantic-release-bot
002d049501
chore(release): 0.39.0 [skip ci]
...
## [0.39.0](https://github.com/propeller-heads/tycho-execution/compare/0.38.0...0.39.0 ) (2025-02-14)
### Features
* **univ4:** Implement swapping with multiple hops ([21a8c1a21a8c1a27abe7883abe7883affc69d03f069d03f06084d0f5ce4d0f5cec648a8bc698a8bc697eb
2025-02-14 17:11:31 +00:00
dianacarvalho1
165e53e5fe
Merge pull request #67 from propeller-heads/router/dc/ENG-4222-univ4-refactor-input
...
feat(univ4): Refactor execution input and handle all swap cases
2025-02-14 17:08:43 +00:00
Diana Carvalho
69d03f0608
fix: Fix PLE tests that break after foundry update
...
--- don't change below this line ---
ENG-4222 Took 12 minutes
Took 15 seconds
2025-02-14 12:39:36 +00:00
Diana Carvalho
8a8bc697eb
fix(univ4): Make slither happy
...
--- don't change below this line ---
ENG-4222 Took 17 minutes
Took 47 seconds
Took 14 seconds
2025-02-14 12:39:36 +00:00
Diana Carvalho
4d0f5cec64
fix(univ4): Append callback data instead of prepending
...
Bring back tests on the executor level. This way the executor can actually be used alone
--- don't change below this line ---
ENG-4222 Took 12 minutes
2025-02-14 12:02:07 +00:00
Diana Carvalho
21a8c1a27a
feat(univ4): Implement swapping with multiple hops
...
--- don't change below this line ---
ENG-4222 Took 47 minutes
2025-02-14 12:02:07 +00:00
Diana Carvalho
be7883affc
feat(univ4): Refactor input and handle single swap case
...
Construct the uniswap v4 specific objects inside the executor
The swap test in the executor alone doesn't work anymore because of the callback data prepended to the rest of he calldata
--- don't change below this line ---
ENG-4222 Took 4 hours 0 minutes
Took 40 seconds
2025-02-14 12:02:07 +00:00
TAMARA LIPOWSKI
556af0253d
test: Add test for USV4 sequential swap
2025-02-14 00:51:06 -05:00
TAMARA LIPOWSKI
b452372714
refactor: deduplicate validation for Split & USV4 strategy
...
We use the same validation for both SplitSwapStrategy and UniswapV4Strategy - so, instead, put the validation into a Validator trait that gets initialized in both swap strategies in order to avoid duplication.
2025-02-13 15:30:09 -05:00
TAMARA LIPOWSKI
f32210bb1f
feat: (WIP) UniswapV4 encoding
...
- To keep any knowledge of USV4 separate from regular splits, I've made a new USV4 encoding strategy that will be used only if we detect sequential USV4 swaps.
- For single USV4 swaps without necessary optimizations, the regular split swap strategy can be used
- No need to change the swap struct interface to take multiple swaps - this concatenation can be done at the swap strategy level.
TODO:
- test
- deduplicate code from split strategy
- UniswapV4SwapEncoder
2025-02-13 14:51:08 -05:00
semantic-release-bot
bb7c6c25a5
chore(release): 0.38.0 [skip ci]
...
## [0.38.0](https://github.com/propeller-heads/tycho-execution/compare/0.37.0...0.38.0 ) (2025-02-13)
### Features
* Add a production foundry profile ([dae38cedae38ceaf9591d73b591d73ba714c5e3bf4c5e3bf6a9
2025-02-13 12:12:02 +00:00
dianacarvalho1
52a3c966cb
Merge pull request #64 from propeller-heads/router/dc/ENG-4223-uniswap-v4-callback
...
feat: Uniswap v4 callback
2025-02-13 12:09:19 +00:00
Diana Carvalho
dae38ceaf9
feat: Add a production foundry profile
...
It can be used with FOUNDRY_PROFILE=production forge build
--- don't change below this line ---
ENG-4223 Took 15 minutes
2025-02-13 12:00:59 +00:00
Diana Carvalho
4c5e3bf6a9
fix: Verify that the executor exists in the uni v4 callback
...
--- don't change below this line ---
ENG-4223 Took 10 minutes
2025-02-13 12:00:59 +00:00
Diana Carvalho
591d73ba71
feat: Support uniswap v4 callback in TychoRouter
...
Make TychoRouter inherit from SafeCallback and then delegatecall to the UniswapV4 executor
Add a test for this. I had to update the block of our forked network in the tests. Because of this I had to update all the asserts in previous tests
Had to change the optimizer_runs in foundry.toml because of weird Yul errors when compiling
--- don't change below this line ---
ENG-4223 Took 1 hour 21 minutes
Took 7 seconds
Took 35 seconds
2025-02-13 12:00:59 +00:00
Diana Carvalho
29eb50d0a1
chore: Create a UniswapV4Utils with encoding functions
...
--- don't change below this line ---
ENG-4223 Took 4 hours 33 minutes
Took 2 minutes
Took 28 minutes
2025-02-13 12:00:59 +00:00
semantic-release-bot
28bfe2e32a
chore(release): 0.37.0 [skip ci]
...
## [0.37.0](https://github.com/propeller-heads/tycho-execution/compare/0.36.2...0.37.0 ) (2025-02-12)
### Features
* add callback ([ed90cb4ed90cb4ef17ca647f7ca647f009e62c332e62c3324514599f074599f07df0cb4c8f4cb4c8f4e51b2097cab2097ca4a5c264084c264084783d998c88d998c88cfebdd3dafbdd3daffbad790682d79068282ab47cff3b47cff3fc9a8cc84da8cc84ddce0c40e9e0c40e9e979ae0b07bae0b07b2a42371ab22371ab2a1fff3209bff3209b1c81a36c331a36c33bc624d4e7624d4e762a2
2025-02-12 20:01:08 +00:00
Harsh Vardhan Roy
f7380b95e4
Merge pull request #58 from propeller-heads/router/hr/ENG-4105-uniswap-v4-executor
2025-02-13 01:29:21 +05:30
royvardhan
d79068282a
fix: _pay and msgSender
2025-02-13 00:25:26 +05:30
royvardhan
0c40e9e979
fix: handle native token balance changes
2025-02-13 00:25:26 +05:30
royvardhan
fe48c64e8e
chore: change balance checks naming
2025-02-13 00:25:26 +05:30
royvardhan
2371ab2a1f
fix: remove executeActions wrapper, strict equality checks and rename swap return
2025-02-13 00:25:26 +05:30
royvardhan
b47cff3fc9
fix: add equality check, amountInOrOut check, update _decodeData
2025-02-13 00:25:26 +05:30
royvardhan
ff3209b1c8
fix: remove extra _receiver and redundant asserts
2025-02-13 00:25:26 +05:30
royvardhan
a555683257
chore: consistent naming
2025-02-13 00:25:26 +05:30
royvardhan
120c96215f
chore: remove redundant data from _decodeData
2025-02-13 00:25:25 +05:30
royvardhan
a8cc84ddce
fix: git submodules and strict equality check in v4 executor
2025-02-13 00:25:25 +05:30
royvardhan
d998c88cfe
feat: support multi swap decoding
2025-02-13 00:25:25 +05:30
royvardhan
c264084783
feat: move encoding to test
2025-02-13 00:25:25 +05:30
royvardhan
ae0b07b2a4
fix: reciever issue
2025-02-13 00:25:25 +05:30
royvardhan
7ca647f009
feat: add new pair test
2025-02-13 00:25:25 +05:30
royvardhan
4599f07df0
feat: add test for UniswapV4Executor
2025-02-13 00:25:25 +05:30
royvardhan
e62c332451
feat: add router params
2025-02-13 00:25:25 +05:30
royvardhan
bdd3daffba
feat: update solc and add V4Router into UniswapV4Executor
2025-02-13 00:25:25 +05:30
royvardhan
24d4e762a2
fix: rm redundant transfer
2025-02-13 00:25:25 +05:30
royvardhan
1a36c33bc6
fix: rm callback fn
2025-02-13 00:25:25 +05:30
royvardhan
b2097ca4a5
feat: handle amounts in unlockCallback
2025-02-13 00:25:25 +05:30
royvardhan
ed90cb4ef1
feat: add callback
2025-02-13 00:25:25 +05:30
royvardhan
cb4c8f4e51
feat: add univ4 executor
2025-02-13 00:25:25 +05:30
semantic-release-bot
00fe142952
chore(release): 0.36.2 [skip ci]
...
## [0.36.2](https://github.com/propeller-heads/tycho-execution/compare/0.36.1...0.36.2 ) (2025-02-12)
### Bug Fixes
* Miscellaneous audit remarks ([582533f582533fa31
2025-02-12 09:54:29 +00:00
dianacarvalho1
3ce384ea16
Merge pull request #63 from propeller-heads/router/dc/ENG-4226-misc-audit-remarks
...
fix: Miscellaneous audit remarks
2025-02-12 09:51:39 +00:00
Diana Carvalho
582533fa31
fix: Miscellaneous audit remarks
...
- Move pause functions together
- Add missing zero checks
- Use openzepplin's sendValues instead of transfer
--- don't change below this line ---
ENG-4226 Took 25 minutes
Took 2 minutes
2025-02-11 16:35:26 +00:00
semantic-release-bot
0626cea164
chore(release): 0.36.1 [skip ci]
...
## [0.36.1](https://github.com/propeller-heads/tycho-execution/compare/0.36.0...0.36.1 ) (2025-02-11)
2025-02-11 16:33:23 +00:00
Tamara
135994f13a
Merge pull request #61 from propeller-heads/encoding/tnl/small-misc-fixes
...
refactor: (Solution) replace check_amount with checked_amount
2025-02-11 11:31:37 -05:00
