- Instead, add a new attribute to the builder, constants, and executor addresses json
- This was a miscommunication. Regular pools will still have the same name - only those with hooks will have hook appended to it
Use SwapBuilder everywhere inside crate
Integration tests will be done later
--- don't change below this line ---
ENG-4696 Took 1 hour 56 minutes
Took 4 minutes
Make specific quotes that are expected to be used by the TychoRouter for the tests. Do not use the BebopHarness
Commented out Aggregate tests
Took 6 hours 40 minutes
Apparently was not necessary and was causing clippy warnings.
```
warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
--> src/encoding/models.rs:91:32
|
91 | pub protocol_state: Option<&'a Box<dyn ProtocolSim>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn ProtocolSim`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
= note: `#[warn(clippy::borrowed_box)]` on by default
```
Encoding: integration tests are now separate and inside their own test folder
Execution: the final integration test should be inside of the protocol test file now and not in TychoRouterProtocolIntegration.t.sol. For this I had to move the BebopExecutionHarness.t.sol outside of the Bebop test file (because of imports)
Took 24 minutes
# Commit time for manual adjustment:
# Took 2 minutes
Because we don't know the size of hook data, it needs to be at the end of the protocol data. But we also don't know the size of the intermediary swaps. To solve this, we are now ple encoding the intermediary swaps and only then appending the hook data
Took 2 hours 50 minutes
Took 40 seconds
Add hook address to encoded data and then use it in execution
Add execution test for Euler
Took 1 hour 19 minutes
Took 2 hours 40 minutes
Took 3 minutes
Took 2 minutes
- Move encoding integration tests to integration test folder (in the rust project)
- Move protocol integration tests be inside the protocol file. This way we can change the block without any problems and it is easier for integrators
Took 6 minutes
Took 6 minutes
Took 17 minutes
