TAMARA LIPOWSKI
c4455dcabb
refactor: Separate test files for split/sequential/single
...
- Add more test cases for sequential swap and single swap to match those of split swap (fee, slippage), to catch errors more easily if someone makes a small code change to either the single or sequential methods
- Excluded USV3 and USV4 tests on sequential and single swap, since these tests were more to test USV3 and USV4 executor functionality than the high level sswap methods - they should already be sufficiently tested.
- Remove `testSplitSwapSimple` and `testSplitSwapSingleUSV3` since this is already tested by several other high-level methods (see single USV3 and single USV4 tests). We should prioritize integration-testing public methods over private methods.
2025-04-23 12:26:31 +01:00
TAMARA LIPOWSKI
1dad4afb6b
feat: Decode single and sequential swaps in LibSwap
...
- The old way was useful when we just had split swaps. Unfortunately, we now have split, sequential, and single swaps, which don't always require token indices or split percentages, so we need to decode differently for each case.
2025-04-23 12:26:31 +01:00
TAMARA LIPOWSKI
3ae9d3ad67
feat: Add sequential swap methods
...
- Add some basic tests (will add more in next commits)
- Adapt sequential tests (which originally tested split swap)
- Adapt a forgotten single swap test
TODO:
- Fix encoding of single and sequential swaps to not expect the split sawp format every time (the split and the token indices are not necessary and consume unnecessary gas).
2025-04-23 12:26:31 +01:00
TAMARA LIPOWSKI
49e0c49828
chore: (single swap) remove unnecessary cycle check
...
- It's not possible to have a single cyclical swap.
2025-04-23 12:26:31 +01:00
TAMARA LIPOWSKI
64345663d0
feat: Single swap methods.
...
- Remove duplicate test case for single swp with permit2. This test came from the days when we could still have a 0 minimum amount.
2025-04-23 12:26:31 +01:00
TAMARA LIPOWSKI
65178681e0
docs: Rename to splitSwap in helper method docs too
...
Took 4 minutes
2025-04-23 12:26:31 +01:00
TAMARA LIPOWSKI
7fc008a718
feat: Rename split swap interfaces
...
- In preparation for adding single and sequential swap methods.
2025-04-23 12:25:36 +01:00
Diana Carvalho
27c9c53889
feat: Add check to don't support cyclical swaps with native actions
...
Remove unnecessary tests and improve comments
--- don't change below this line ---
ENG-4331 Took 30 minutes
2025-03-13 17:34:50 +00:00
royvardhan
ec26890d00
test: add assert in cyclic swap encoding tests
2025-03-12 00:49:42 +05:30
royvardhan
eb4ce40f6e
test: add testCyclicSwapUnwrapOutputIntegration in encoder and testCyclicSwapUnwrapOutputIntegration test
2025-03-12 00:49:42 +05:30
royvardhan
b7c1619796
docs: make cyclic test ref addresses lowercase
2025-03-12 00:49:42 +05:30
royvardhan
6c31906733
chore: cleanup
2025-03-12 00:49:42 +05:30
royvardhan
525560ea16
chore: cleanup
2025-03-12 00:49:42 +05:30
royvardhan
bd504a8fed
test: update test_split_input_cyclic_swap to use usv2 in the last swap
2025-03-12 00:49:42 +05:30
royvardhan
0edc201f06
test: add test_split_output_cyclic_swap in encoder, and testCyclicSplitOutputSwapIntegration integration test
2025-03-12 00:49:42 +05:30
royvardhan
3a6e933ce9
test: fix test_split_input_cyclic_swap and testCyclicSplitSwapIntegration
2025-03-12 00:49:42 +05:30
royvardhan
0a0101cc4d
test: add testCyclicSplitSwapIntegration
2025-03-12 00:49:42 +05:30
royvardhan
79d6c020fa
misc: fix _swapChecked for cyclic swap, update encoder swap path validation, add cyclic sequesntial swap integration test
2025-03-12 00:49:42 +05:30
royvardhan
91f36fe328
fix: amountConsumed check in _swapChecked for cyclic swap
2025-03-10 23:32:30 +05:30
Harsh Vardhan Roy
38cdf28e7e
docs: update testSplitInputCyclicSwap
...
Co-authored-by: Tamara <tamara@datarevenue.com >
2025-03-10 23:25:38 +05:30
royvardhan
34d5ac6e1c
test: update testSplitInputCyclicSwap to use all WETH for USDC
2025-03-10 22:20:13 +05:30
royvardhan
bd6f74ca9c
docs: update docs at testSplitInputCyclicSwap and testSplitOutputCyclicSwap
2025-03-10 18:12:58 +05:30
royvardhan
bb10efc0cc
docs: update docs at _swap and testSplitOutputCyclicSwap
2025-03-10 18:12:58 +05:30
royvardhan
4d67df4096
feat: add cyclicSwapAmountOut tracker in _swap, add split cylic tests
2025-03-10 18:12:58 +05:30
royvardhan
66c00df4f1
test: add testCyclicSplitSwap test and update var naming in testCyclicSequentialSwap
2025-03-10 18:12:58 +05:30
royvardhan
57acbd58c5
fix: remove amountIn addition to amountOut in _swap for cyclic swaps, add testCyclicSwapWithTwoPools test to verify
2025-03-10 18:12:58 +05:30
TAMARA LIPOWSKI
b74d4c9e25
chore: remove unnecessary min amount check, doc fix
2025-03-06 10:37:37 -05:00
Tamara
9821ab0c00
Merge branch 'main' into router/tnl/basescan-verify
2025-03-05 13:15:37 -05:00
TAMARA LIPOWSKI
09208b342a
test: Add testSwapCheckedUndefinedMinAmount
...
To check if the swap actually reverts when min amount is 0.
2025-03-05 13:06:06 -05:00
Diana Carvalho
5c28d77f1d
feat: Check min amount out is not zero
...
Update tests
--- don't change below this line ---
ENG-4286 Took 57 minutes
Took 20 seconds
2025-03-05 17:53:51 +00:00
royvardhan
7833086425
fix: TychoRouter swap check test naming and docs
2025-03-05 22:23:16 +05:30
Harsh Vardhan Roy
2086484898
docs: remove unnecessary comment from swap
...
Co-authored-by: Tamara <tamara@datarevenue.com >
2025-03-05 22:23:16 +05:30
royvardhan
f853739a3d
feat: add transferFrom in swap and move core swap logic inside _swapChecked
2025-03-05 22:23:16 +05:30
Harsh Vardhan Roy
013113c4d9
Merge branch 'main' into router/hr/ENG-4280-gas-test
2025-03-05 21:32:40 +05:30
royvardhan
a3bffd4f75
fix: add amountIn in error TychoRouter__AmountInDiffersFromConsumed
2025-03-05 00:45:22 +05:30
royvardhan
6f421eb374
fix: inequality check for amountConsumed and amountIn
2025-03-05 00:35:51 +05:30
TAMARA LIPOWSKI
bc54eac110
feat: Rename Etherscan in deployment verification
...
This could also be Basescan. Abstract away to blockchain explorer.
2025-03-03 17:14:39 -05:00
Diana Carvalho
db9c8cde5a
fix: Make permit2 permit an action in the universal router
...
--- don't change below this line ---
ENG-4286 Took 1 hour 35 minutes
2025-03-03 18:33:22 +00:00
Harsh Vardhan Roy
d3e0e066fa
Merge branch 'main' into router/hr/ENG-4280-gas-test
2025-03-01 00:11:34 +05:30
royvardhan
ec8d59eeae
test: remove gas usage numbers from GasTest
2025-03-01 00:09:15 +05:30
royvardhan
6f69748ba4
test: update gas usage numbers in GasTest
2025-02-28 22:02:21 +05:30
royvardhan
5db95781e5
test: add isPermit2 bool in GasTest for readability
2025-02-28 10:11:04 +05:30
TAMARA LIPOWSKI
33973a65b8
fix: make USV2 factory configurable in Executor
...
- This factory is not the same for Ethereum and Base, so Base txs were failing when verifying pool addresses.
- I've double checked that we don't have this problem for Balancer V2 - the vault address in the same on Base and on Ethereum Mainnet.
2025-02-27 23:15:08 -05:00
royvardhan
9014fc7383
test: add permit2 tests for simple swaps in TychoRouter and GasTest
2025-02-28 00:40:56 +05:30
royvardhan
35e706d6ea
test: add GasTest to compare with Universal Router gas usage
2025-02-28 00:40:56 +05:30
Diana Carvalho
fedc5043db
feat: Deploy to mainnet (again)
...
--- don't change below this line ---
ENG-4260 Took 22 minutes
2025-02-27 18:01:15 +00:00
Diana Carvalho
59eb2195b6
feat: Change license to SPDX-License-Identifier: UNLICENSED everywhere
...
Remove unnecessary files
--- don't change below this line ---
ENG-4260 Took 13 minutes
2025-02-27 17:38:53 +00:00
Diana Carvalho
3d65ac8cd9
feat: Deploy to mainnet. Update all addresses
...
--- don't change below this line ---
ENG-4260 Took 27 minutes
Took 10 seconds
2025-02-27 17:25:54 +00:00
Diana Carvalho
79045e2689
feat: Verify contracts on etherscan
...
--- don't change below this line ---
ENG-4260 Took 31 minutes
2025-02-27 15:52:32 +00:00
Diana Carvalho
d011c4b475
Merge branch 'refs/heads/main' into router/dc/deploy-executors
2025-02-27 15:00:17 +00:00
