Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,159 Commits 1 Branch 0 Tags
689fdd6a5880520e18c74ebeba1ef05bc97bc33a
Commit Graph

291 Commits

Author SHA1 Message Date
royvardhan
6f421eb374 fix: inequality check for amountConsumed and amountIn 2025-03-05 00:35:51 +05:30
TAMARA LIPOWSKI
33973a65b8 fix: make USV2 factory configurable in Executor 
- This factory is not the same for Ethereum and Base, so Base txs were failing when verifying pool addresses.
- I've double checked that we don't have this problem for Balancer V2 - the vault address in the same on Base and on Ethereum Mainnet.
 2025-02-27 23:15:08 -05:00
Diana Carvalho
59eb2195b6 feat: Change license to SPDX-License-Identifier: UNLICENSED everywhere 
Remove unnecessary files

--- don't change below this line ---
ENG-4260 Took 13 minutes
 2025-02-27 17:38:53 +00:00
royvardhan
0273f58274 fix: remove 0 amount check in _unwrapEth 2025-02-27 20:08:49 +05:30
Harsh Vardhan Roy
393ed61595 docs: update _unwrapEth docs 
Co-authored-by: Tamara <tamara@datarevenue.com>
 2025-02-27 20:08:49 +05:30
royvardhan
353861f738 refactor: update unwrapEth to only check 0 amount 2025-02-27 20:08:49 +05:30
royvardhan
7b0dd5872c chore: merge main 2025-02-26 23:26:27 +05:30
royvardhan
0be69c9aea refactor: check if amountIn was fully consumed based on balance changes 2025-02-26 19:04:26 +05:30
royvardhan
53d48f1bac refactor: centralize swap logic to reduce duplication between swap and swapPermit2 2025-02-26 18:05:29 +05:30
dianacarvalho1
6008d5e836 Merge branch 'main' into router/dc/ENG-4260-improve-receive 2025-02-26 09:40:58 +00:00
TAMARA LIPOWSKI
857522134b chore: forge fmt 
kill blank lines
 2025-02-25 13:14:30 -05:00
TAMARA LIPOWSKI
abef1e062e style: TychoRouter ascii art 2025-02-25 13:10:29 -05:00
Diana Carvalho
801976fafa fix: Restrict receive callers to have code 
--- don't change below this line ---
ENG-4260 Took 8 minutes
 2025-02-25 09:36:04 +00:00
royvardhan
892726e07b chore: cleanup 2025-02-24 21:41:19 +05:30
royvardhan
69745b18fd feat: rm selector from usv3, usv4, update tests, and rename dispatcher file 2025-02-24 17:16:27 +05:30
royvardhan
58116e074a feat: hardcode callback and swap selection in dispatcher 2025-02-24 10:56:17 +05:30
royvardhan
4b77128df2 chore: rename _computePairAddress to _verifyPairAddress, add fake v2 pool in v2 test file 2025-02-22 00:26:15 +05:30
royvardhan
2f1507dd0e test: add target verification tests for usv2, usv3 2025-02-21 23:28:03 +05:30
royvardhan
7936ba1c94 feat: add target verification for usv2 and usv3 using _computePairAddress 2025-02-21 23:28:03 +05:30
Diana Carvalho
0ba5d02268 feat: Use openzepplin's sendValue instead of send for ETH transfers 
--- don't change below this line ---
ENG-4260 Took 7 minutes
 2025-02-21 17:07:46 +00:00
TAMARA LIPOWSKI
a7aa4d7ebb fix: Native ETH input/output integration tests/fixes 
- Only for single swaps
- Used USV4 for this because it's the only DEX we support that allows native ETH swaps
- For Native ETH input single swaps, we need to properly check the remaining amount (we were treating them wronly like ERC20 tokens)
- For Native ETH output single swaps, we were passing the incorrect currency (the settle always needs to be the out token and the take always needs to be the in token, this should not depend on the zeroForOne value).
 2025-02-21 00:23:24 -05:00
TAMARA LIPOWSKI
d65d575003 feat: Don't encode min amount for USV4 
We aren't checking min amount for any other executor. This would be overkill (since we are already checking in the main router) and also inconsistent.
 2025-02-20 12:15:40 -05:00
TAMARA LIPOWSKI
2d267792f3 docs: Fixed outdated comments 
Some copypastas, some other improvements.
 2025-02-20 10:46:27 -05:00
TAMARA LIPOWSKI
c3482a509a feat: TychoRouter swap method not requiring Permit2 
- Assume the tokens have been transferred into our router beforehand.
 2025-02-19 16:15:57 -05:00
Diana Carvalho
c940d8b536 docs(univ3): Add comment explaining msg.data 
Took 55 minutes
 2025-02-18 14:59:26 +00:00
Diana Carvalho
2aa63d7ec0 feat: Change signature of _handleCallback to take only bytes calldata 
The selector and executor are decoded inside this function now.
For Uniswap V3 I had to manually slice the msg.data from uniswapV3SwapCallback to get the data that matters for the callback

Took 3 hours 12 minutes
 2025-02-18 11:11:43 +00:00
royvardhan
2604935609 chore: update unlockCallback and uniswapV3SwapCallback 2025-02-17 22:51:40 +05:30
Harsh Vardhan Roy
0d5c55c546 Merge branch 'main' into router/hr/ENG-4237-refactor-usv3-callback 2025-02-17 21:56:49 +05:30
royvardhan
076586d776 feat: update _handleCallback, add verifyCallback with docs 2025-02-17 21:51:09 +05:30
royvardhan
14e5c127c6 chore: rm safecallback from router 2025-02-15 01:06:23 +05:30
royvardhan
9b8175aff9 chore: cleanup 2025-02-15 01:01:16 +05:30
royvardhan
ad91e485d3 feat: rename execution dispatcher to dispatcher and use dispatcher for USV4 callback 2025-02-15 00:44:28 +05:30
royvardhan
9d3b96f997 feat: add uniswapV3SwapCallback in USV3 executor 2025-02-15 00:34:07 +05:30
royvardhan
cccb252bf2 feat: update handleCallback in USV3 to do verification 2025-02-14 23:27:44 +05:30
royvardhan
d0027e6cf2 refactor: rm callback verifier dispatcher 2025-02-14 23:11:01 +05:30
royvardhan
260f9d866f feat: add back uniswapV3SwapCallback in router 2025-02-14 23:00:23 +05:30
Diana Carvalho
8a8bc697eb fix(univ4): Make slither happy 
--- don't change below this line ---
ENG-4222 Took 17 minutes

Took 47 seconds


Took 14 seconds
 2025-02-14 12:39:36 +00:00
Diana Carvalho
4d0f5cec64 fix(univ4): Append callback data instead of prepending 
Bring back tests on the executor level. This way the executor can actually be used alone

--- don't change below this line ---
ENG-4222 Took 12 minutes
 2025-02-14 12:02:07 +00:00
Diana Carvalho
21a8c1a27a feat(univ4): Implement swapping with multiple hops 
--- don't change below this line ---
ENG-4222 Took 47 minutes
 2025-02-14 12:02:07 +00:00
Diana Carvalho
be7883affc feat(univ4): Refactor input and handle single swap case 
Construct the uniswap v4 specific objects inside the executor
The swap test in the executor alone doesn't work anymore because of the callback data prepended to the rest of he calldata

--- don't change below this line ---
ENG-4222 Took 4 hours 0 minutes


Took 40 seconds
 2025-02-14 12:02:07 +00:00
royvardhan
5853de679a feat: move callback testing to usv3 executor 2025-02-14 01:29:30 +05:30
royvardhan
80500e615e feat: fix input decoding in usv3 executor and execution dispatcher 2025-02-14 00:53:43 +05:30
royvardhan
bd1971334e feat: update new interface in codebase 2025-02-13 20:54:54 +05:30
royvardhan
a309825769 refactor: rm usv3 callback from router and add generic callback to executor 2025-02-13 20:31:21 +05:30
Diana Carvalho
4c5e3bf6a9 fix: Verify that the executor exists in the uni v4 callback 
--- don't change below this line ---
ENG-4223 Took 10 minutes
 2025-02-13 12:00:59 +00:00
Diana Carvalho
591d73ba71 feat: Support uniswap v4 callback in TychoRouter 
Make TychoRouter inherit from SafeCallback and then delegatecall to the UniswapV4 executor
Add a test for this. I had to update the block of our forked network in the tests. Because of this I had to update all the asserts in previous tests

Had to change the optimizer_runs in foundry.toml because of weird Yul errors when compiling

--- don't change below this line ---
ENG-4223 Took 1 hour 21 minutes

Took 7 seconds


Took 35 seconds
 2025-02-13 12:00:59 +00:00
royvardhan
d79068282a fix: _pay and msgSender 2025-02-13 00:25:26 +05:30
royvardhan
0c40e9e979 fix: handle native token balance changes 2025-02-13 00:25:26 +05:30
royvardhan
fe48c64e8e chore: change balance checks naming 2025-02-13 00:25:26 +05:30
royvardhan
2371ab2a1f fix: remove executeActions wrapper, strict equality checks and rename swap return 2025-02-13 00:25:26 +05:30