royvardhan
69745b18fd
feat: rm selector from usv3, usv4, update tests, and rename dispatcher file
2025-02-24 17:16:27 +05:30
royvardhan
58116e074a
feat: hardcode callback and swap selection in dispatcher
2025-02-24 10:56:17 +05:30
royvardhan
4b77128df2
chore: rename _computePairAddress to _verifyPairAddress, add fake v2 pool in v2 test file
2025-02-22 00:26:15 +05:30
royvardhan
2f1507dd0e
test: add target verification tests for usv2, usv3
2025-02-21 23:28:03 +05:30
royvardhan
7936ba1c94
feat: add target verification for usv2 and usv3 using _computePairAddress
2025-02-21 23:28:03 +05:30
TAMARA LIPOWSKI
a7aa4d7ebb
fix: Native ETH input/output integration tests/fixes
...
- Only for single swaps
- Used USV4 for this because it's the only DEX we support that allows native ETH swaps
- For Native ETH input single swaps, we need to properly check the remaining amount (we were treating them wronly like ERC20 tokens)
- For Native ETH output single swaps, we were passing the incorrect currency (the settle always needs to be the out token and the take always needs to be the in token, this should not depend on the zeroForOne value).
2025-02-21 00:23:24 -05:00
TAMARA LIPOWSKI
d65d575003
feat: Don't encode min amount for USV4
...
We aren't checking min amount for any other executor. This would be overkill (since we are already checking in the main router) and also inconsistent.
2025-02-20 12:15:40 -05:00
Diana Carvalho
2aa63d7ec0
feat: Change signature of _handleCallback to take only bytes calldata
...
The selector and executor are decoded inside this function now.
For Uniswap V3 I had to manually slice the msg.data from uniswapV3SwapCallback to get the data that matters for the callback
Took 3 hours 12 minutes
2025-02-18 11:11:43 +00:00
royvardhan
2604935609
chore: update unlockCallback and uniswapV3SwapCallback
2025-02-17 22:51:40 +05:30
Harsh Vardhan Roy
0d5c55c546
Merge branch 'main' into router/hr/ENG-4237-refactor-usv3-callback
2025-02-17 21:56:49 +05:30
royvardhan
076586d776
feat: update _handleCallback, add verifyCallback with docs
2025-02-17 21:51:09 +05:30
royvardhan
9b8175aff9
chore: cleanup
2025-02-15 01:01:16 +05:30
royvardhan
9d3b96f997
feat: add uniswapV3SwapCallback in USV3 executor
2025-02-15 00:34:07 +05:30
royvardhan
cccb252bf2
feat: update handleCallback in USV3 to do verification
2025-02-14 23:27:44 +05:30
royvardhan
d0027e6cf2
refactor: rm callback verifier dispatcher
2025-02-14 23:11:01 +05:30
royvardhan
260f9d866f
feat: add back uniswapV3SwapCallback in router
2025-02-14 23:00:23 +05:30
Diana Carvalho
8a8bc697eb
fix(univ4): Make slither happy
...
--- don't change below this line ---
ENG-4222 Took 17 minutes
Took 47 seconds
Took 14 seconds
2025-02-14 12:39:36 +00:00
Diana Carvalho
4d0f5cec64
fix(univ4): Append callback data instead of prepending
...
Bring back tests on the executor level. This way the executor can actually be used alone
--- don't change below this line ---
ENG-4222 Took 12 minutes
2025-02-14 12:02:07 +00:00
Diana Carvalho
21a8c1a27a
feat(univ4): Implement swapping with multiple hops
...
--- don't change below this line ---
ENG-4222 Took 47 minutes
2025-02-14 12:02:07 +00:00
Diana Carvalho
be7883affc
feat(univ4): Refactor input and handle single swap case
...
Construct the uniswap v4 specific objects inside the executor
The swap test in the executor alone doesn't work anymore because of the callback data prepended to the rest of he calldata
--- don't change below this line ---
ENG-4222 Took 4 hours 0 minutes
Took 40 seconds
2025-02-14 12:02:07 +00:00
royvardhan
5853de679a
feat: move callback testing to usv3 executor
2025-02-14 01:29:30 +05:30
royvardhan
80500e615e
feat: fix input decoding in usv3 executor and execution dispatcher
2025-02-14 00:53:43 +05:30
royvardhan
bd1971334e
feat: update new interface in codebase
2025-02-13 20:54:54 +05:30
royvardhan
a309825769
refactor: rm usv3 callback from router and add generic callback to executor
2025-02-13 20:31:21 +05:30
royvardhan
d79068282a
fix: _pay and msgSender
2025-02-13 00:25:26 +05:30
royvardhan
0c40e9e979
fix: handle native token balance changes
2025-02-13 00:25:26 +05:30
royvardhan
fe48c64e8e
chore: change balance checks naming
2025-02-13 00:25:26 +05:30
royvardhan
2371ab2a1f
fix: remove executeActions wrapper, strict equality checks and rename swap return
2025-02-13 00:25:26 +05:30
royvardhan
b47cff3fc9
fix: add equality check, amountInOrOut check, update _decodeData
2025-02-13 00:25:26 +05:30
royvardhan
ff3209b1c8
fix: remove extra _receiver and redundant asserts
2025-02-13 00:25:26 +05:30
royvardhan
120c96215f
chore: remove redundant data from _decodeData
2025-02-13 00:25:25 +05:30
royvardhan
a8cc84ddce
fix: git submodules and strict equality check in v4 executor
2025-02-13 00:25:25 +05:30
royvardhan
d998c88cfe
feat: support multi swap decoding
2025-02-13 00:25:25 +05:30
royvardhan
c264084783
feat: move encoding to test
2025-02-13 00:25:25 +05:30
royvardhan
ae0b07b2a4
fix: reciever issue
2025-02-13 00:25:25 +05:30
royvardhan
4599f07df0
feat: add test for UniswapV4Executor
2025-02-13 00:25:25 +05:30
royvardhan
e62c332451
feat: add router params
2025-02-13 00:25:25 +05:30
royvardhan
bdd3daffba
feat: update solc and add V4Router into UniswapV4Executor
2025-02-13 00:25:25 +05:30
royvardhan
24d4e762a2
fix: rm redundant transfer
2025-02-13 00:25:25 +05:30
royvardhan
1a36c33bc6
fix: rm callback fn
2025-02-13 00:25:25 +05:30
royvardhan
b2097ca4a5
feat: handle amounts in unlockCallback
2025-02-13 00:25:25 +05:30
royvardhan
ed90cb4ef1
feat: add callback
2025-02-13 00:25:25 +05:30
royvardhan
cb4c8f4e51
feat: add univ4 executor
2025-02-13 00:25:25 +05:30
TAMARA LIPOWSKI
92b4ee00d3
chore: remove unused factory variable
2025-01-29 19:53:22 -05:00
TAMARA LIPOWSKI
ca32446a9e
feat: UniswapV3Executor and integration tests
...
- Note: I think we can get the fee straight from the pool... why did we always encode this and send it from the solver? Is this bound to change sometimes?
2025-01-29 19:51:17 -05:00
Harsh Vardhan Roy
cb6d165e7f
feat: approve max
2025-01-28 23:49:28 +05:30
royvardhan
b85428212a
fix: slither
2025-01-28 22:59:02 +05:30
royvardhan
b1ca478294
fix: ci
2025-01-28 22:54:31 +05:30
Harsh Vardhan Roy
6af6780f2e
Merge branch 'main' into router/hr/ENG-4035-Balancer-V2-Executor
2025-01-28 22:43:02 +05:30
royvardhan
7a83eddc92
fix: slither
2025-01-28 22:38:26 +05:30
