From 9bb0d9bc8495f4fff9006d9ed7e353042c023c9c Mon Sep 17 00:00:00 2001 From: TAMARA LIPOWSKI Date: Fri, 28 Feb 2025 13:49:59 -0500 Subject: [PATCH] feat: Rename ETH_RPC_URL -> RPC_URL We support multiple chains so this may not just be ETH, but perhaps a Base URL for example. --- .github/workflows/tests-and-lints-template.yaml | 2 +- src/encoding/evm/approvals/permit2.rs | 2 +- src/encoding/evm/approvals/protocol_approvals_manager.rs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests-and-lints-template.yaml b/.github/workflows/tests-and-lints-template.yaml index e39c451..70f431b 100644 --- a/.github/workflows/tests-and-lints-template.yaml +++ b/.github/workflows/tests-and-lints-template.yaml @@ -25,7 +25,7 @@ permissions: env: CARGO_TERM_COLOR: always - ETH_RPC_URL: ${{ secrets.eth_rpc_url }} + RPC_URL: ${{ secrets.eth_rpc_url }} jobs: compile_and_test: diff --git a/src/encoding/evm/approvals/permit2.rs b/src/encoding/evm/approvals/permit2.rs index 9eb6c3e..f1a5153 100644 --- a/src/encoding/evm/approvals/permit2.rs +++ b/src/encoding/evm/approvals/permit2.rs @@ -269,7 +269,7 @@ mod tests { /// This test actually calls the permit method on the Permit2 contract to verify the encoded /// data works. It requires an Anvil fork, so please run with the following command: anvil - /// --fork-url And set up the following env var as ETH_RPC_URL=127.0.0.1:8545 + /// --fork-url And set up the following env var as RPC_URL=127.0.0.1:8545 /// Use an account from anvil to fill the anvil_account and anvil_private_key variables #[test] #[cfg_attr(not(feature = "fork-tests"), ignore)] diff --git a/src/encoding/evm/approvals/protocol_approvals_manager.rs b/src/encoding/evm/approvals/protocol_approvals_manager.rs index d239f73..4b06a85 100644 --- a/src/encoding/evm/approvals/protocol_approvals_manager.rs +++ b/src/encoding/evm/approvals/protocol_approvals_manager.rs @@ -75,8 +75,8 @@ impl ProtocolApprovalsManager { /// Gets the client used for interacting with the EVM-compatible network. pub async fn get_client() -> Result>, EncodingError> { dotenv().ok(); - let eth_rpc_url = env::var("ETH_RPC_URL") - .map_err(|_| EncodingError::FatalError("Missing ETH_RPC_URL in environment".to_string()))?; + let eth_rpc_url = env::var("RPC_URL") + .map_err(|_| EncodingError::FatalError("Missing RPC_URL in environment".to_string()))?; let client = ProviderBuilder::new() .on_builtin(ð_rpc_url) .await