chore: keep test naming consistent
This commit is contained in:
@@ -51,14 +51,14 @@ contract LibPrefixLengthEncodedByteArrayTest is Test {
|
|||||||
assertEq(this.size(multiple), 3);
|
assertEq(this.size(multiple), 3);
|
||||||
}
|
}
|
||||||
|
|
||||||
function test_RevertIf_InvalidLength() public {
|
function testInvalidLength() public {
|
||||||
// Length prefix larger than remaining data
|
// Length prefix larger than remaining data
|
||||||
vm.expectRevert();
|
vm.expectRevert();
|
||||||
bytes memory invalid = hex"0004414243";
|
bytes memory invalid = hex"0004414243";
|
||||||
this.next(invalid);
|
this.next(invalid);
|
||||||
}
|
}
|
||||||
|
|
||||||
function test_RevertIf_IncompletePrefix() public {
|
function testIncompletePrefix() public {
|
||||||
// Only 1 byte instead of 2 bytes prefix
|
// Only 1 byte instead of 2 bytes prefix
|
||||||
vm.expectRevert();
|
vm.expectRevert();
|
||||||
bytes memory invalid = hex"01";
|
bytes memory invalid = hex"01";
|
||||||
|
|||||||
@@ -80,7 +80,7 @@ contract UniswapV2ExecutorTest is UniswapV2ExecutorExposed, Test, Constants {
|
|||||||
uniswapV2Exposed.verifyPairAddress(WETH_DAI_POOL);
|
uniswapV2Exposed.verifyPairAddress(WETH_DAI_POOL);
|
||||||
}
|
}
|
||||||
|
|
||||||
function test_RevertIf_InvalidTarget() public {
|
function testInvalidTarget() public {
|
||||||
address fakePool = address(new FakeUniswapV2Pool(WETH_ADDR, DAI_ADDR));
|
address fakePool = address(new FakeUniswapV2Pool(WETH_ADDR, DAI_ADDR));
|
||||||
vm.expectRevert(UniswapV2Executor__InvalidTarget.selector);
|
vm.expectRevert(UniswapV2Executor__InvalidTarget.selector);
|
||||||
uniswapV2Exposed.verifyPairAddress(fakePool);
|
uniswapV2Exposed.verifyPairAddress(fakePool);
|
||||||
@@ -145,7 +145,7 @@ contract UniswapV2ExecutorTest is UniswapV2ExecutorExposed, Test, Constants {
|
|||||||
assertGe(finalBalance, amountOut);
|
assertGe(finalBalance, amountOut);
|
||||||
}
|
}
|
||||||
|
|
||||||
function test_RevertIf_Swap_InvalidTarget() public {
|
function testSwapFailureInvalidTarget() public {
|
||||||
uint256 amountIn = 10 ** 18;
|
uint256 amountIn = 10 ** 18;
|
||||||
bool zeroForOne = false;
|
bool zeroForOne = false;
|
||||||
address fakePool = address(new FakeUniswapV2Pool(WETH_ADDR, DAI_ADDR));
|
address fakePool = address(new FakeUniswapV2Pool(WETH_ADDR, DAI_ADDR));
|
||||||
|
|||||||
@@ -128,7 +128,7 @@ contract UniswapV3ExecutorTest is Test, Constants {
|
|||||||
assertGe(IERC20(DAI_ADDR).balanceOf(address(this)), expAmountOut);
|
assertGe(IERC20(DAI_ADDR).balanceOf(address(this)), expAmountOut);
|
||||||
}
|
}
|
||||||
|
|
||||||
function test_RevertIf_InvalidTarget() public {
|
function testSwapFailureInvalidTarget() public {
|
||||||
uint256 amountIn = 10 ** 18;
|
uint256 amountIn = 10 ** 18;
|
||||||
deal(WETH_ADDR, address(uniswapV3Exposed), amountIn);
|
deal(WETH_ADDR, address(uniswapV3Exposed), amountIn);
|
||||||
bool zeroForOne = false;
|
bool zeroForOne = false;
|
||||||
|
|||||||
Reference in New Issue
Block a user