feat: Remove special handling of the Univ4 callback
The problem was that the pool manager was expecting an ABI encoded result to be returned and we were not returning that (we were returning just a result) Special thanks to Max for figuring this out Took 31 minutes
This commit is contained in:
@@ -184,8 +184,11 @@ contract UniswapV4Executor is
|
||||
external
|
||||
returns (bytes memory)
|
||||
{
|
||||
verifyCallback(data);
|
||||
return _unlockCallback(data);
|
||||
bytes calldata stripped = data[68:];
|
||||
verifyCallback(stripped);
|
||||
// Our general callback logic returns a not ABI encoded result.
|
||||
// However, the pool manager expects the result to be ABI encoded. That is why we need to encode it here again.
|
||||
return abi.encode(_unlockCallback(stripped));
|
||||
}
|
||||
|
||||
function verifyCallback(bytes calldata) public view poolManagerOnly {}
|
||||
|
||||
Reference in New Issue
Block a user