Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Renamings + comment fixes

Browse Source 
- Renamed ExecutorTransferMethods to TokenTransfer to avoid leaking information about how the transfer happens into the executor. The executor shouldn't care if there are multiple methods or one single method that takes care of everything.
- Also renamed TransferMethod to TransferType to match the rust encoding
This commit is contained in:
TAMARA LIPOWSKI
2025-04-10 11:02:04 -04:00
committed by Diana Carvalho
parent e8f56ff088
commit ee7495551e
3 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
foundry/src/executors/ExecutorTransferMethods.sol
View File

1
foundry/src/executors/TokenTransfer.sol
View File

@@ -50,3 +50,4 @@ contract TokenTransfer {
} }
} }
} }

4
foundry/test/executors/UniswapV3Executor.t.sol
View File

@@ -90,9 +90,7 @@ contract UniswapV3ExecutorTest is Test, Constants, Permit2TestHelper {
assertEq(receiver, address(2)); assertEq(receiver, address(2));
assertEq(target, address(3)); assertEq(target, address(3));
assertEq(zeroForOne, false); assertEq(zeroForOne, false);
assertEq( assertEq(uint8(transferType), uint8(TokenTransfer.TransferType.TRANSFER));
uint8(transferType), uint8(TokenTransfer.TransferType.TRANSFER)
);
} }
function testDecodeParamsInvalidDataLength() public { function testDecodeParamsInvalidDataLength() public {