fix: Make all tests pass!

Delete TokenTransfer.sol
Make slither happy

Bugfixes:
- Executors
  - Ekubo:
    - Fix the POOL_DATA_OFFSET value and remove sender from callback data
    - Use SafeERC20
  - Maverick and Univ2: Use safeTransfer and not safeTransferFrom
  - Univ3: update expected data length
  - Univ4: update the selectors (the signature changed)
- Router:
  - For split swap we don't need to pass the tokenInReceiver, it should always be the router address
  - For single and sequential: change order of the parameters (to be before the permit2 specific objects)
- Encoders:
  - Update selector signatures
  - For split swap pass the transfer_from (we might not need to if the token in is ETH)

Took 2 hours 51 minutes
This commit is contained in:
Diana Carvalho
2025-05-15 13:11:34 +01:00
parent 27dfde3118
commit ee687038c5
20 changed files with 126 additions and 197 deletions

View File

@@ -95,10 +95,9 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
false,
4,
ALICE,
true,
permitSingle,
signature,
true,
tychoRouterAddr,
pleEncode(swaps)
);
@@ -127,7 +126,6 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
4,
ALICE,
true,
tychoRouterAddr,
pleEncode(swaps)
);
@@ -157,7 +155,6 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
4,
ALICE,
true,
tychoRouterAddr,
pleEncode(swaps)
);
vm.stopPrank();
@@ -184,7 +181,6 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
2,
ALICE,
true,
tychoRouterAddr,
pleEncode(swaps)
);
@@ -222,10 +218,9 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
false,
4,
ALICE,
true,
permitSingle,
signature,
true,
tychoRouterAddr,
pleEncode(swaps)
);
vm.stopPrank();
@@ -268,10 +263,9 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
false,
2,
ALICE,
false,
emptyPermitSingle,
"",
false,
tychoRouterAddr,
pleEncode(swaps)
);
uint256 expectedAmount = 2018817438608734439722;
@@ -315,10 +309,9 @@ contract TychoRouterSplitSwapTest is TychoRouterTestSetup {
true,
2,
ALICE,
true,
permitSingle,
signature,
true,
tychoRouterAddr,
pleEncode(swaps)
);