fix: Make all tests pass!

Delete TokenTransfer.sol
Make slither happy

Bugfixes:
- Executors
  - Ekubo:
    - Fix the POOL_DATA_OFFSET value and remove sender from callback data
    - Use SafeERC20
  - Maverick and Univ2: Use safeTransfer and not safeTransferFrom
  - Univ3: update expected data length
  - Univ4: update the selectors (the signature changed)
- Router:
  - For split swap we don't need to pass the tokenInReceiver, it should always be the router address
  - For single and sequential: change order of the parameters (to be before the permit2 specific objects)
- Encoders:
  - Update selector signatures
  - For split swap pass the transfer_from (we might not need to if the token in is ETH)

Took 2 hours 51 minutes
This commit is contained in:
Diana Carvalho
2025-05-15 13:11:34 +01:00
parent 27dfde3118
commit ee687038c5
20 changed files with 126 additions and 197 deletions

View File

@@ -40,10 +40,10 @@ contract TychoRouterSingleSwapTest is TychoRouterTestSetup {
false,
false,
ALICE,
permitSingle,
signature,
true, // transferFrom to WETH_DAI_POOL
WETH_DAI_POOL, // receiver of input tokens
permitSingle,
signature,
swap
);
@@ -239,10 +239,10 @@ contract TychoRouterSingleSwapTest is TychoRouterTestSetup {
true,
false,
ALICE,
false,
tychoRouterAddr,
emptyPermitSingle,
"",
true,
tychoRouterAddr,
swap
);
uint256 expectedAmount = 2018817438608734439722;
@@ -280,10 +280,10 @@ contract TychoRouterSingleSwapTest is TychoRouterTestSetup {
false,
true,
ALICE,
permitSingle,
signature,
true, // transferFrom to WETH_DAI_POOL
WETH_DAI_POOL, // receiver of input tokens
permitSingle,
signature,
swap
);