Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: replace setExecutor with batchSetExecutor

Browse Source
This commit is contained in:
royvardhan
2025-01-30 18:58:54 +05:30
parent 1b79326637
commit ea504faca1
4 changed files with 38 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
foundry/src/TychoRouter.sol
View File

@@ -235,13 +235,15 @@ contract TychoRouter is
/**
* @dev Entrypoint to add or replace an approved executor contract address
* @param target address of the executor contract
* @param targets address of the executor contract
*/
function setExecutor(address target)
function batchSetExecutor(address[] memory targets)
external
onlyRole(EXECUTOR_SETTER_ROLE)
{
_setExecutor(target);
for (uint256 i = 0; i < targets.length; i++) {
_setExecutor(targets[i]);
}
}
/**

5
foundry/test/Constants.sol
View File

@@ -16,6 +16,7 @@ contract Constants is Test {
// Dummy contracts
address DUMMY = makeAddr("dummy");
address DUMMY2 = makeAddr("dummy2");
address PAUSER = makeAddr("pauser");
address UNPAUSER = makeAddr("unpauser");
@@ -37,6 +38,8 @@ contract Constants is Test {
*/
function deployDummyContract() internal {
bytes memory minimalBytecode = hex"01"; // Single-byte bytecode
vm.etch(DUMMY, minimalBytecode); // Deploy minimal bytecode
// Deploy minimal bytecode
vm.etch(DUMMY, minimalBytecode);
vm.etch(DUMMY2, minimalBytecode);
}
}

25
foundry/test/TychoRouter.t.sol
View File

@@ -20,15 +20,32 @@ contract TychoRouterTest is TychoRouterTestSetup {
);
function testSetExecutorValidRole() public {
// Set single executor
address[] memory executors = new address[](1);
executors[0] = DUMMY;
vm.startPrank(EXECUTOR_SETTER);
tychoRouter.setExecutor(DUMMY);
tychoRouter.batchSetExecutor(executors);
vm.stopPrank();
assert(tychoRouter.executors(DUMMY) == true);
}
function testSetExecutorMultipleValidRole() public {
// Set multiple executors
address[] memory executors = new address[](2);
executors[0] = DUMMY;
executors[1] = DUMMY2;
vm.startPrank(EXECUTOR_SETTER);
tychoRouter.batchSetExecutor(executors);
vm.stopPrank();
assert(tychoRouter.executors(DUMMY) == true);
assert(tychoRouter.executors(DUMMY2) == true);
}
function testRemoveExecutorValidRole() public {
vm.startPrank(EXECUTOR_SETTER);
tychoRouter.setExecutor(DUMMY);
address[] memory executors = new address[](1);
executors[0] = DUMMY;
tychoRouter.batchSetExecutor(executors);
tychoRouter.removeExecutor(DUMMY);
vm.stopPrank();
assert(tychoRouter.executors(DUMMY) == false);
@@ -41,7 +58,9 @@ contract TychoRouterTest is TychoRouterTestSetup {
function testSetExecutorMissingSetterRole() public {
vm.expectRevert();
tychoRouter.setExecutor(DUMMY);
address[] memory executors = new address[](1);
executors[0] = DUMMY;
tychoRouter.batchSetExecutor(executors);
}
function testSetVerifierValidRole() public {

4
foundry/test/TychoRouterTestSetup.sol
View File

@@ -56,7 +56,9 @@ contract TychoRouterTestSetup is Test, Constants {
usv2Executor = new UniswapV2Executor();
vm.startPrank(EXECUTOR_SETTER);
tychoRouter.setExecutor(address(usv2Executor));
address[] memory executors = new address[](1);
executors[0] = address(usv2Executor);
tychoRouter.batchSetExecutor(executors);
vm.stopPrank();
vm.startPrank(BOB);