From 9accc843460254d57866dff50af9d132b0ce0ed2 Mon Sep 17 00:00:00 2001 From: TAMARA LIPOWSKI Date: Wed, 26 Mar 2025 09:56:44 +0100 Subject: [PATCH 01/10] docs: Clarify validation criteria for cyclical swaps --- src/encoding/evm/tycho_encoder.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/encoding/evm/tycho_encoder.rs b/src/encoding/evm/tycho_encoder.rs index 183e215..bc8ba14 100644 --- a/src/encoding/evm/tycho_encoder.rs +++ b/src/encoding/evm/tycho_encoder.rs @@ -54,6 +54,8 @@ impl EVMTychoEncoder { /// swap's input is the chain's wrapped token. /// * If the solution is unwrapping, the checked token is the chain's native token and the last /// swap's output is the chain's wrapped token. + /// * The token cannot appear more than once in the solution unless it is the first and last + /// token (i.e. a true cyclical swap). fn validate_solution(&self, solution: &Solution) -> Result<(), EncodingError> { if solution.exact_out { return Err(EncodingError::FatalError( From 58e2ddd50e131c484ad53a6dca0b09e1d221d0e5 Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 15:42:58 +0300 Subject: [PATCH 02/10] fix: fixed git checkout for codelint --- .github/workflows/tests-and-lints-template.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-and-lints-template.yaml b/.github/workflows/tests-and-lints-template.yaml index 12cd28a..4cd9a14 100644 --- a/.github/workflows/tests-and-lints-template.yaml +++ b/.github/workflows/tests-and-lints-template.yaml @@ -92,7 +92,7 @@ jobs: - name: Checkout uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 with: - ref: ${{ github.head_ref }} + ref: refs/pull/${{ github.event.pull_request.number }}/head - name: Setup git to use https run: | From af0197205adb3220673022b690f1d8aa6f6734aa Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 16:10:14 +0300 Subject: [PATCH 03/10] fix: test run outside a PR --- .github/workflows/ci-test.yaml | 19 +++++++++++++++++++ .github/workflows/evm-foundry-ci.yml | 4 ++-- .github/workflows/slither.yml | 6 +++--- .../workflows/tests-and-lints-template.yaml | 2 +- 4 files changed, 25 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/ci-test.yaml diff --git a/.github/workflows/ci-test.yaml b/.github/workflows/ci-test.yaml new file mode 100644 index 0000000..8c45407 --- /dev/null +++ b/.github/workflows/ci-test.yaml @@ -0,0 +1,19 @@ +name: Continuous Integration + +on: + push: + branches: + - fix/git-checkout-stage-fix + +permissions: + id-token: write + contents: read + +jobs: + tests-and-lints: + uses: ./.github/workflows/tests-and-lints-template.yaml + secrets: + eth_rpc_url: ${{ secrets.ETH_RPC_URL }} + app_id: ${{ secrets.APP_ID }} + app_private_key: ${{ secrets.APP_PRIVATE_KEY }} + diff --git a/.github/workflows/evm-foundry-ci.yml b/.github/workflows/evm-foundry-ci.yml index ee56fa0..be7c9b8 100644 --- a/.github/workflows/evm-foundry-ci.yml +++ b/.github/workflows/evm-foundry-ci.yml @@ -13,12 +13,12 @@ jobs: env: RPC_URL: ${{ secrets.ETH_RPC_URL }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 with: submodules: recursive - name: Install Foundry - uses: foundry-rs/foundry-toolchain@v1 + uses: foundry-rs/foundry-toolchain@de808b1eea699e761c404bda44ba8f21aba30b2c - name: Check formatting run: forge fmt --check diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index 4134b29..dc18ce8 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -10,8 +10,8 @@ jobs: analyze: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - uses: crytic/slither-action@v0.4.0 + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 + - uses: crytic/slither-action@f197989dea5b53e986d0f88c60a034ddd77ec9a8 with: target: 'foundry/' - slither-args: '--filter-paths foundry/lib/' \ No newline at end of file + slither-args: '--filter-paths foundry/lib/' diff --git a/.github/workflows/tests-and-lints-template.yaml b/.github/workflows/tests-and-lints-template.yaml index 4cd9a14..947695d 100644 --- a/.github/workflows/tests-and-lints-template.yaml +++ b/.github/workflows/tests-and-lints-template.yaml @@ -92,7 +92,7 @@ jobs: - name: Checkout uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 with: - ref: refs/pull/${{ github.event.pull_request.number }}/head + ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} - name: Setup git to use https run: | From 9f7d605ea5e76d230b5946c618ece76365fb4f02 Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 16:13:52 +0300 Subject: [PATCH 04/10] fix: prepared lint workflow for external contributors --- .github/workflows/ci-test.yaml | 19 ------------------- 1 file changed, 19 deletions(-) delete mode 100644 .github/workflows/ci-test.yaml diff --git a/.github/workflows/ci-test.yaml b/.github/workflows/ci-test.yaml deleted file mode 100644 index 8c45407..0000000 --- a/.github/workflows/ci-test.yaml +++ /dev/null @@ -1,19 +0,0 @@ -name: Continuous Integration - -on: - push: - branches: - - fix/git-checkout-stage-fix - -permissions: - id-token: write - contents: read - -jobs: - tests-and-lints: - uses: ./.github/workflows/tests-and-lints-template.yaml - secrets: - eth_rpc_url: ${{ secrets.ETH_RPC_URL }} - app_id: ${{ secrets.APP_ID }} - app_private_key: ${{ secrets.APP_PRIVATE_KEY }} - From b3c4dbc293df758ff4cff949298a819436d83c38 Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 16:27:32 +0300 Subject: [PATCH 05/10] fix: added empty line --- .github/workflows/slither.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index dc18ce8..242b864 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -15,3 +15,4 @@ jobs: with: target: 'foundry/' slither-args: '--filter-paths foundry/lib/' + From ae5d7deaccfc1ac527f88371bb3f055b01689801 Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 16:29:53 +0300 Subject: [PATCH 06/10] fix: removed empty line --- .github/workflows/slither.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index 242b864..dc18ce8 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -15,4 +15,3 @@ jobs: with: target: 'foundry/' slither-args: '--filter-paths foundry/lib/' - From fdb015118f756fb8017413736f5d8cc308ebfe35 Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Thu, 27 Mar 2025 13:35:43 +0000 Subject: [PATCH 07/10] chore(release): 0.67.1 [skip ci] ## [0.67.1](https://github.com/propeller-heads/tycho-execution/compare/0.67.0...0.67.1) (2025-03-27) ### Bug Fixes * added empty line ([b3c4dbc](https://github.com/propeller-heads/tycho-execution/commit/b3c4dbc293df758ff4cff949298a819436d83c38)) * fixed git checkout for codelint ([58e2ddd](https://github.com/propeller-heads/tycho-execution/commit/58e2ddd50e131c484ad53a6dca0b09e1d221d0e5)) * prepared lint workflow for external contributors ([9f7d605](https://github.com/propeller-heads/tycho-execution/commit/9f7d605ea5e76d230b5946c618ece76365fb4f02)) * removed empty line ([ae5d7de](https://github.com/propeller-heads/tycho-execution/commit/ae5d7deaccfc1ac527f88371bb3f055b01689801)) * test run outside a PR ([af01972](https://github.com/propeller-heads/tycho-execution/commit/af0197205adb3220673022b690f1d8aa6f6734aa)) --- CHANGELOG.md | 11 +++++++++++ Cargo.lock | 2 +- Cargo.toml | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6e0bd10..edb670d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,14 @@ +## [0.67.1](https://github.com/propeller-heads/tycho-execution/compare/0.67.0...0.67.1) (2025-03-27) + + +### Bug Fixes + +* added empty line ([b3c4dbc](https://github.com/propeller-heads/tycho-execution/commit/b3c4dbc293df758ff4cff949298a819436d83c38)) +* fixed git checkout for codelint ([58e2ddd](https://github.com/propeller-heads/tycho-execution/commit/58e2ddd50e131c484ad53a6dca0b09e1d221d0e5)) +* prepared lint workflow for external contributors ([9f7d605](https://github.com/propeller-heads/tycho-execution/commit/9f7d605ea5e76d230b5946c618ece76365fb4f02)) +* removed empty line ([ae5d7de](https://github.com/propeller-heads/tycho-execution/commit/ae5d7deaccfc1ac527f88371bb3f055b01689801)) +* test run outside a PR ([af01972](https://github.com/propeller-heads/tycho-execution/commit/af0197205adb3220673022b690f1d8aa6f6734aa)) + ## [0.67.0](https://github.com/propeller-heads/tycho-execution/compare/0.66.1...0.67.0) (2025-03-20) diff --git a/Cargo.lock b/Cargo.lock index bdbcf8f..546f295 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4340,7 +4340,7 @@ dependencies = [ [[package]] name = "tycho-execution" -version = "0.67.0" +version = "0.67.1" dependencies = [ "alloy", "alloy-primitives", diff --git a/Cargo.toml b/Cargo.toml index b3cd474..611c77d 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "tycho-execution" -version = "0.67.0" +version = "0.67.1" edition = "2021" [[bin]] From 5162b9e19efcaa5a2137f71a94f6f9e7f7d14da0 Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 16:52:00 +0300 Subject: [PATCH 08/10] fix: prepared lint workflow for external contributors --- .github/workflows/ci-test.yaml | 19 +++++++++++++++++++ .../workflows/tests-and-lints-template.yaml | 11 +++++++++-- 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/ci-test.yaml diff --git a/.github/workflows/ci-test.yaml b/.github/workflows/ci-test.yaml new file mode 100644 index 0000000..8c45407 --- /dev/null +++ b/.github/workflows/ci-test.yaml @@ -0,0 +1,19 @@ +name: Continuous Integration + +on: + push: + branches: + - fix/git-checkout-stage-fix + +permissions: + id-token: write + contents: read + +jobs: + tests-and-lints: + uses: ./.github/workflows/tests-and-lints-template.yaml + secrets: + eth_rpc_url: ${{ secrets.ETH_RPC_URL }} + app_id: ${{ secrets.APP_ID }} + app_private_key: ${{ secrets.APP_PRIVATE_KEY }} + diff --git a/.github/workflows/tests-and-lints-template.yaml b/.github/workflows/tests-and-lints-template.yaml index 947695d..6c10017 100644 --- a/.github/workflows/tests-and-lints-template.yaml +++ b/.github/workflows/tests-and-lints-template.yaml @@ -89,10 +89,17 @@ jobs: - name: Install git run: sudo apt update && sudo apt install -y git - - name: Checkout + - name: Checkout PR (from fork or branch) + if: github.event_name == 'pull_request' uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 with: - ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} + ref: refs/pull/${{ github.event.pull_request.number }}/head + + - name: Checkout push branch (main or other) + if: github.event_name != 'pull_request' + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 + with: + ref: ${{ github.ref }} - name: Setup git to use https run: | From 9896f4882940517d61852300420c7c580138406f Mon Sep 17 00:00:00 2001 From: Valentin Khramtsov Date: Thu, 27 Mar 2025 16:53:29 +0300 Subject: [PATCH 09/10] fix: prepared lint workflow for external contributors --- .github/workflows/ci-test.yaml | 19 ------------------- 1 file changed, 19 deletions(-) delete mode 100644 .github/workflows/ci-test.yaml diff --git a/.github/workflows/ci-test.yaml b/.github/workflows/ci-test.yaml deleted file mode 100644 index 8c45407..0000000 --- a/.github/workflows/ci-test.yaml +++ /dev/null @@ -1,19 +0,0 @@ -name: Continuous Integration - -on: - push: - branches: - - fix/git-checkout-stage-fix - -permissions: - id-token: write - contents: read - -jobs: - tests-and-lints: - uses: ./.github/workflows/tests-and-lints-template.yaml - secrets: - eth_rpc_url: ${{ secrets.ETH_RPC_URL }} - app_id: ${{ secrets.APP_ID }} - app_private_key: ${{ secrets.APP_PRIVATE_KEY }} - From 382fab0b463272c77d69812d1ddf520a02e4a539 Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Thu, 27 Mar 2025 14:08:30 +0000 Subject: [PATCH 10/10] chore(release): 0.67.2 [skip ci] ## [0.67.2](https://github.com/propeller-heads/tycho-execution/compare/0.67.1...0.67.2) (2025-03-27) ### Bug Fixes * prepared lint workflow for external contributors ([9896f48](https://github.com/propeller-heads/tycho-execution/commit/9896f4882940517d61852300420c7c580138406f)) * prepared lint workflow for external contributors ([5162b9e](https://github.com/propeller-heads/tycho-execution/commit/5162b9e19efcaa5a2137f71a94f6f9e7f7d14da0)) --- CHANGELOG.md | 8 ++++++++ Cargo.lock | 2 +- Cargo.toml | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index edb670d..3f8e5c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,11 @@ +## [0.67.2](https://github.com/propeller-heads/tycho-execution/compare/0.67.1...0.67.2) (2025-03-27) + + +### Bug Fixes + +* prepared lint workflow for external contributors ([9896f48](https://github.com/propeller-heads/tycho-execution/commit/9896f4882940517d61852300420c7c580138406f)) +* prepared lint workflow for external contributors ([5162b9e](https://github.com/propeller-heads/tycho-execution/commit/5162b9e19efcaa5a2137f71a94f6f9e7f7d14da0)) + ## [0.67.1](https://github.com/propeller-heads/tycho-execution/compare/0.67.0...0.67.1) (2025-03-27) diff --git a/Cargo.lock b/Cargo.lock index 546f295..c1c2b94 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4340,7 +4340,7 @@ dependencies = [ [[package]] name = "tycho-execution" -version = "0.67.1" +version = "0.67.2" dependencies = [ "alloy", "alloy-primitives", diff --git a/Cargo.toml b/Cargo.toml index 611c77d..f0a0725 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "tycho-execution" -version = "0.67.1" +version = "0.67.2" edition = "2021" [[bin]]