diff --git a/src/encoding/evm/strategy_encoder/encoder.rs b/src/encoding/evm/strategy_encoder/encoder.rs index e1660f6..7068608 100644 --- a/src/encoding/evm/strategy_encoder/encoder.rs +++ b/src/encoding/evm/strategy_encoder/encoder.rs @@ -65,7 +65,7 @@ impl StrategyEncoder for StraightToPoolStrategyEncoder { let encoding_context = EncodingContext { receiver: solution.receiver, exact_out: solution.exact_out, - address_for_approvals: router_address, + router_address, }; let protocol_data = swap_encoder.encode_swap(swap.clone(), encoding_context)?; // TODO: here we need to pass also the address of the executor to be used diff --git a/src/encoding/evm/swap_encoder/encoders.rs b/src/encoding/evm/swap_encoder/encoders.rs index 8eecc5f..14421e7 100644 --- a/src/encoding/evm/swap_encoder/encoders.rs +++ b/src/encoding/evm/swap_encoder/encoders.rs @@ -90,7 +90,7 @@ impl SwapEncoder for BalancerV2SwapEncoder { ) -> Result, EncodingError> { let token_approvals_manager = ProtocolApprovalsManager::new(); let token = bytes_to_address(&swap.token_in)?; - let router_address = bytes_to_address(&encoding_context.address_for_approvals)?; + let router_address = bytes_to_address(&encoding_context.router_address)?; let approval_needed = token_approvals_manager.approval_needed(token, router_address, self.vault_address)?; // should we return gas estimation here too?? if there is an approval needed, gas will be @@ -133,7 +133,7 @@ mod tests { let encoding_context = EncodingContext { receiver: Bytes::from("0x0000000000000000000000000000000000000001"), exact_out: false, - address_for_approvals: Bytes::zero(20), + router_address: Bytes::zero(20), }; let encoder = super::UniswapV2SwapEncoder::new(String::from("0x")); let encoded_swap = encoder diff --git a/src/encoding/models.rs b/src/encoding/models.rs index cda2eee..c5f0907 100644 --- a/src/encoding/models.rs +++ b/src/encoding/models.rs @@ -76,6 +76,5 @@ pub struct Transaction { pub struct EncodingContext { pub receiver: Bytes, pub exact_out: bool, - // TODO I don't like this - what does this mean? - pub address_for_approvals: Bytes, + pub router_address: Bytes, }