Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Use forceApprove instead of regular Approve

Browse Source 
This is necessary for USDT (it was failing)

--- don't change below this line ---
ENG-4307 Took 29 minutes
This commit is contained in:
Diana Carvalho
2025-04-10 15:44:02 +01:00
parent 9e68ab8b01
commit c963f3b2f6
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
foundry/src/executors/CurveExecutor.sol
View File

@@ -62,7 +62,7 @@ contract CurveExecutor is IExecutor {
if (tokenApprovalNeeded && tokenIn != nativeToken) { if (tokenApprovalNeeded && tokenIn != nativeToken) {
// slither-disable-next-line unused-return // slither-disable-next-line unused-return
IERC20(tokenIn).approve(address(pool), type(uint256).max); IERC20(tokenIn).forceApprove(address(pool), type(uint256).max);
} }
/// Inspired by Curve's router contract: https://github.com/curvefi/curve-router-ng/blob/9ab006ca848fc7f1995b6fbbecfecc1e0eb29e2a/contracts/Router.vy#L44 /// Inspired by Curve's router contract: https://github.com/curvefi/curve-router-ng/blob/9ab006ca848fc7f1995b6fbbecfecc1e0eb29e2a/contracts/Router.vy#L44

8
foundry/test/executors/CurveExecutor.t.sol
View File

@@ -266,16 +266,16 @@ contract CurveExecutorTest is Test, Constants {
function testStableSwapPool() public { function testStableSwapPool() public {
// Swapping CRVUSD -> USDT on a StableSwap pool, deployed by factory 0x4F8846Ae9380B90d2E71D5e3D042dff3E7ebb40d (plain pool) // Swapping CRVUSD -> USDT on a StableSwap pool, deployed by factory 0x4F8846Ae9380B90d2E71D5e3D042dff3E7ebb40d (plain pool)
uint256 amountIn = 1 ether; uint256 amountIn = 1 ether;
deal(CRVUSD_ADDR, address(curveExecutorExposed), amountIn); deal(USDT_ADDR, address(curveExecutorExposed), amountIn);
bytes memory data = bytes memory data =
_getData(CRVUSD_ADDR, USDT_ADDR, CRVUSD_USDT_POOL, 1); _getData(USDT_ADDR, CRVUSD_ADDR, CRVUSD_USDT_POOL, 1);
uint256 amountOut = curveExecutorExposed.swap(amountIn, data); uint256 amountOut = curveExecutorExposed.swap(amountIn, data);
assertEq(amountOut, 999910); assertEq(amountOut, 10436946786333182306400100);
assertEq( assertEq(
IERC20(USDT_ADDR).balanceOf(address(curveExecutorExposed)), IERC20(CRVUSD_ADDR).balanceOf(address(curveExecutorExposed)),
amountOut amountOut
); );
} }