From c65306202783ec80e8086423a4cec4261728da03 Mon Sep 17 00:00:00 2001 From: royvardhan Date: Thu, 30 Jan 2025 19:29:24 +0530 Subject: [PATCH] feat: rename batchSetExecutor to setExecutors --- foundry/src/TychoRouter.sol | 2 +- foundry/test/TychoRouter.t.sol | 12 ++++++------ foundry/test/TychoRouterTestSetup.sol | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/foundry/src/TychoRouter.sol b/foundry/src/TychoRouter.sol index ed2ebe3..93fc8ee 100644 --- a/foundry/src/TychoRouter.sol +++ b/foundry/src/TychoRouter.sol @@ -237,7 +237,7 @@ contract TychoRouter is * @dev Entrypoint to add or replace an approved executor contract address * @param targets address of the executor contract */ - function batchSetExecutor(address[] memory targets) + function setExecutors(address[] memory targets) external onlyRole(EXECUTOR_SETTER_ROLE) { diff --git a/foundry/test/TychoRouter.t.sol b/foundry/test/TychoRouter.t.sol index 017a594..d37c202 100644 --- a/foundry/test/TychoRouter.t.sol +++ b/foundry/test/TychoRouter.t.sol @@ -19,12 +19,12 @@ contract TychoRouterTest is TychoRouterTestSetup { address indexed token, uint256 amount, address indexed receiver ); - function testSetExecutorValidRole() public { + function testSetExecutorsValidRole() public { // Set single executor address[] memory executors = new address[](1); executors[0] = DUMMY; vm.startPrank(EXECUTOR_SETTER); - tychoRouter.batchSetExecutor(executors); + tychoRouter.setExecutors(executors); vm.stopPrank(); assert(tychoRouter.executors(DUMMY) == true); } @@ -35,7 +35,7 @@ contract TychoRouterTest is TychoRouterTestSetup { executors[0] = DUMMY; executors[1] = DUMMY2; vm.startPrank(EXECUTOR_SETTER); - tychoRouter.batchSetExecutor(executors); + tychoRouter.setExecutors(executors); vm.stopPrank(); assert(tychoRouter.executors(DUMMY) == true); assert(tychoRouter.executors(DUMMY2) == true); @@ -45,7 +45,7 @@ contract TychoRouterTest is TychoRouterTestSetup { vm.startPrank(EXECUTOR_SETTER); address[] memory executors = new address[](1); executors[0] = DUMMY; - tychoRouter.batchSetExecutor(executors); + tychoRouter.setExecutors(executors); tychoRouter.removeExecutor(DUMMY); vm.stopPrank(); assert(tychoRouter.executors(DUMMY) == false); @@ -56,11 +56,11 @@ contract TychoRouterTest is TychoRouterTestSetup { tychoRouter.removeExecutor(BOB); } - function testSetExecutorMissingSetterRole() public { + function testSetExecutorsMissingSetterRole() public { vm.expectRevert(); address[] memory executors = new address[](1); executors[0] = DUMMY; - tychoRouter.batchSetExecutor(executors); + tychoRouter.setExecutors(executors); } function testSetVerifierValidRole() public { diff --git a/foundry/test/TychoRouterTestSetup.sol b/foundry/test/TychoRouterTestSetup.sol index dc5e713..0470bad 100644 --- a/foundry/test/TychoRouterTestSetup.sol +++ b/foundry/test/TychoRouterTestSetup.sol @@ -58,7 +58,7 @@ contract TychoRouterTestSetup is Test, Constants { vm.startPrank(EXECUTOR_SETTER); address[] memory executors = new address[](1); executors[0] = address(usv2Executor); - tychoRouter.batchSetExecutor(executors); + tychoRouter.setExecutors(executors); vm.stopPrank(); vm.startPrank(BOB);