fix: Silence slither warnings

- low level calls are fine, since we are checking for success, and we have already checked for contract existence when setting swap executors
- dead-code is silenced
- fix solidity version
This commit is contained in:
TAMARA LIPOWSKI
2025-01-23 15:07:56 -05:00
parent 825af0f8d7
commit b616e11354
2 changed files with 4 additions and 1 deletions

View File

@@ -1,5 +1,5 @@
// SPDX-License-Identifier: UNLICENSED
pragma solidity >=0.7.5;
pragma solidity ^0.8.28;
import "@openzeppelin/contracts/token/ERC20/IERC20.sol";

View File

@@ -24,6 +24,7 @@ contract SwapExecutionDispatcher {
* @dev Calls an executor, assumes swap.protocolData contains
* token addresses if required by the executor.
*/
// slither-disable-next-line dead-code
function _callSwapExecutor(uint256 amount, bytes calldata data)
internal
returns (uint256 calculatedAmount)
@@ -43,6 +44,7 @@ contract SwapExecutionDispatcher {
revert SwapExecutionDispatcher__UnapprovedExecutor();
}
// slither-disable-next-line low-level-calls
(bool success, bytes memory result) = executor.delegatecall(
abi.encodeWithSelector(selector, amount, protocolData)
);
@@ -60,6 +62,7 @@ contract SwapExecutionDispatcher {
calculatedAmount = abi.decode(result, (uint256));
}
// slither-disable-next-line dead-code
function _decodeExecutorAndSelector(bytes calldata data)
internal
pure