From 8a7c39052d45ee75e81cbb267748a1fc635a8c34 Mon Sep 17 00:00:00 2001 From: Diana Carvalho Date: Fri, 2 May 2025 12:47:03 +0100 Subject: [PATCH 1/3] feat: Propagate the entire result of the callback --- don't change below this line --- ENG-4476 Took 41 minutes --- foundry/src/TychoRouter.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/foundry/src/TychoRouter.sol b/foundry/src/TychoRouter.sol index 55be637..379f0e7 100644 --- a/foundry/src/TychoRouter.sol +++ b/foundry/src/TychoRouter.sol @@ -661,8 +661,8 @@ contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard { bytes memory result = _callHandleCallbackOnExecutor(msg.data); // slither-disable-next-line assembly assembly ("memory-safe") { - // Propagate the calculatedAmount - return(add(result, 32), 16) + // Propagate the result + return(add(result, 32), mload(result)) } } From 04000059e5e7940f209639c900557b437a766913 Mon Sep 17 00:00:00 2001 From: Diana Carvalho Date: Fri, 2 May 2025 12:48:03 +0100 Subject: [PATCH 2/3] feat: Change revert condition in _wrapETH --- don't change below this line --- ENG-4476 Took 1 minute --- foundry/src/TychoRouter.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundry/src/TychoRouter.sol b/foundry/src/TychoRouter.sol index 379f0e7..4d9d7b7 100644 --- a/foundry/src/TychoRouter.sol +++ b/foundry/src/TychoRouter.sol @@ -757,7 +757,7 @@ contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard { * @param amount of native ETH to wrap. */ function _wrapETH(uint256 amount) internal { - if (msg.value > 0 && msg.value != amount) { + if (msg.value != amount) { revert TychoRouter__MessageValueMismatch(msg.value, amount); } _weth.deposit{value: amount}(); From c4b9a1d76915baaa07e214c016d176374ff83179 Mon Sep 17 00:00:00 2001 From: Diana Carvalho Date: Fri, 2 May 2025 12:55:04 +0100 Subject: [PATCH 3/3] docs: Mention audits in the README --- don't change below this line --- ENG-4476 Took 6 minutes --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index eec77c7..5f289da 100644 --- a/README.md +++ b/README.md @@ -13,6 +13,11 @@ For complete documentation, see Tycho docs [here](https://docs.propellerheads.xy To get started on encoding, have a look at our [Encoding example](examples/encoding-example/README.md). For a complete example please refer to the [Tycho Quickstart guide](https://docs.propellerheads.xyz/tycho). -## Report a Vulnerability +## Security + +All audits of the Tycho Router and Executor contracts can be found [here](docs/audits). +The vulnerabilities discovered during the audits have been acknowledged and addressed or accepted. + +### Report a Vulnerability Contact [security@propellerheads.xyz](mailto:security@propellerheads.xyz) \ No newline at end of file