From 9eda00cbb69f70f597998cfe078da806907b4fb3 Mon Sep 17 00:00:00 2001 From: TAMARA LIPOWSKI Date: Thu, 20 Feb 2025 11:51:08 -0500 Subject: [PATCH] chore: PR comments --- foundry/test/TychoRouter.t.sol | 5 ++--- src/encoding/evm/strategy_encoder/strategy_encoders.rs | 4 ---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/foundry/test/TychoRouter.t.sol b/foundry/test/TychoRouter.t.sol index 540baa8..75417a2 100644 --- a/foundry/test/TychoRouter.t.sol +++ b/foundry/test/TychoRouter.t.sol @@ -744,12 +744,11 @@ contract TychoRouterTest is TychoRouterTestSetup { // deal(USDC_ADDR, ALICE, 1 ether); uint256 balancerBefore = IERC20(PEPE_ADDR).balanceOf(ALICE); - console.logAddress(address(usv4Executor)); // Approve permit2 vm.startPrank(ALICE); IERC20(USDC_ADDR).approve(address(permit2Address), type(uint256).max); - // Encoded solution generated using `test_split_swap_strategy_encoder_simple` + // Encoded solution generated using `test_split_encoding_strategy_usv4` // but manually replacing the executor address // `5c2f5a71f67c01775180adc06909288b4c329308` with the one in this test // `f62849f9a0b5bf2913b396098f7c7019b51a820a` @@ -762,7 +761,7 @@ contract TychoRouterTest is TychoRouterTestSetup { uint256 balancerAfter = IERC20(PEPE_ADDR).balanceOf(ALICE); assertTrue(success, "Call Failed"); - assertGt(balancerAfter - balancerBefore, 26173932); + assertEq(balancerAfter - balancerBefore, 97191013220606467325121599); } function testSingleSwapWithWrapIntegration() public { diff --git a/src/encoding/evm/strategy_encoder/strategy_encoders.rs b/src/encoding/evm/strategy_encoder/strategy_encoders.rs index a72f968..71f5029 100644 --- a/src/encoding/evm/strategy_encoder/strategy_encoders.rs +++ b/src/encoding/evm/strategy_encoder/strategy_encoders.rs @@ -485,8 +485,6 @@ mod tests { }, token_in: usdc.clone(), token_out: eth.clone(), - // This represents the remaining 50%, but to avoid any rounding errors we set this to - // 0 to signify "the remainder of the WETH value". It should still be very close to 50% split: 0f64, }; @@ -911,8 +909,6 @@ mod tests { }, token_in: usdc.clone(), token_out: eth.clone(), - // This represents the remaining 50%, but to avoid any rounding errors we set this to - // 0 to signify "the remainder of the WETH value". It should still be very close to 50% split: 0f64, };