Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(BalancerV3Executor): Slice callback data nicely

Browse Source 
Make a stricter data validation

Took 35 minutes
This commit is contained in:
Diana Carvalho
2025-06-06 17:01:48 +01:00
parent c03df8aa1e
commit 941879d5d6
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
foundry/src/executors/BalancerV3Executor.sol
View File

@@ -87,8 +87,9 @@ contract BalancerV3Executor is IExecutor, RestrictTransferFrom, ICallback {
returns (bytes memory result) returns (bytes memory result)
{ {
verifyCallback(data); verifyCallback(data);
result = _swapCallback(data[68:]); // Remove the first 68 bytes 4 selector + 32 dataOffset + 32 dataLength and extra padding at the end
// Our general callback logic returns a not ABI encoded result. result = _swapCallback(data[68:181]);
// Our general callback logic returns a not ABI encoded result (see Dispatcher._callHandleCallbackOnExecutor).
// However, the Vault expects the result to be ABI encoded. That is why we need to encode it here again. // However, the Vault expects the result to be ABI encoded. That is why we need to encode it here again.
return abi.encode(result); return abi.encode(result);
} }
@@ -112,7 +113,7 @@ contract BalancerV3Executor is IExecutor, RestrictTransferFrom, ICallback {
address receiver address receiver
) )
{ {
if (data.length < 113) { if (data.length != 113) {
revert BalancerV3Executor__InvalidDataLength(); revert BalancerV3Executor__InvalidDataLength();
} }