Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: TokenApprovalsManager should not implement ApprovalsManager

Browse Source 
They should be separate.
ApprovalsManager is only for user approvals
This commit is contained in:
Diana Carvalho
2025-01-14 14:37:14 +00:00
parent 3e609c75ae
commit 93410b4fe2
5 changed files with 22 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/encoding/router_encoder.rs
View File

@@ -1,4 +1,4 @@
use crate::encoding::approvals::interface::{Approval, ApprovalsManager};
use crate::encoding::approvals::interface::{Approval, UserApprovalsManager};
use crate::encoding::models::{Solution, PROPELLER_ROUTER_ADDRESS};
use crate::encoding::strategy_encoder::StrategyEncoder;
use crate::encoding::strategy_selector::StrategySelector;
@@ -6,11 +6,11 @@ use crate::encoding::utils::{encode_input, ple_encode};
use alloy_sol_types::SolValue;
use anyhow::Error;
struct RouterEncoder<S: StrategySelector, A: ApprovalsManager> {
struct RouterEncoder<S: StrategySelector, A: UserApprovalsManager> {
strategy_selector: S,
approvals_manager: A,
}
impl<S: StrategySelector, A: ApprovalsManager> RouterEncoder<S, A> {
impl<S: StrategySelector, A: UserApprovalsManager> RouterEncoder<S, A> {
pub fn new(strategy_selector: S, approvals_manager: A) -> Self {
RouterEncoder {
strategy_selector,