Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: fix input decoding in usv3 executor and execution dispatcher

Browse Source
This commit is contained in:
royvardhan
2025-02-14 00:53:43 +05:30
parent bd1971334e
commit 80500e615e
10 changed files with 237 additions and 321 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
foundry/test/executors/UniswapV3Executor.t.sol
View File

@@ -8,9 +8,7 @@ import {Constants} from "../Constants.sol";
contract UniswapV3ExecutorExposed is UniswapV3Executor {
constructor(address _factory) UniswapV3Executor(_factory) {}
function decodeData(
bytes calldata data
)
function decodeData(bytes calldata data)
external
pure
returns (
@@ -44,12 +42,7 @@ contract UniswapV3ExecutorTest is Test, Constants {
function testDecodeParams() public view {
uint24 expectedPoolFee = 500;
bytes memory data = abi.encodePacked(
WETH_ADDR,
DAI_ADDR,
expectedPoolFee,
address(2),
address(3),
false
WETH_ADDR, DAI_ADDR, expectedPoolFee, address(2), address(3), false
);
(
@@ -70,11 +63,8 @@ contract UniswapV3ExecutorTest is Test, Constants {
}
function testDecodeParamsInvalidDataLength() public {
bytes memory invalidParams = abi.encodePacked(
WETH_ADDR,
address(2),
address(3)
);
bytes memory invalidParams =
abi.encodePacked(WETH_ADDR, address(2), address(3));
vm.expectRevert(UniswapV3Executor__InvalidDataLength.selector);
uniswapV3Exposed.decodeData(invalidParams);