Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: TychoRouter swap check test naming and docs

Browse Source
This commit is contained in:
royvardhan
2025-03-05 22:20:16 +05:30
parent 2086484898
commit 7833086425
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
foundry/test/TychoRouter.t.sol
View File

@@ -420,9 +420,9 @@ contract TychoRouterTest is TychoRouterTestSetup {
// Checks amount out at the end // Checks amount out at the end
uint256 amountIn = 1 ether; uint256 amountIn = 1 ether;
// Approve the tokenIn to be transferred to the router
deal(WETH_ADDR, ALICE, amountIn); deal(WETH_ADDR, ALICE, amountIn);
vm.startPrank(ALICE); vm.startPrank(ALICE);
// Approve the tokenIn to be transferred to the router
IERC20(WETH_ADDR).approve(address(tychoRouterAddr), amountIn); IERC20(WETH_ADDR).approve(address(tychoRouterAddr), amountIn);
bytes memory protocolData = encodeUniswapV2Swap( bytes memory protocolData = encodeUniswapV2Swap(
@@ -459,12 +459,12 @@ contract TychoRouterTest is TychoRouterTestSetup {
function testSwapCheckedLessApprovalFailure() public { function testSwapCheckedLessApprovalFailure() public {
// Trade 1 WETH for DAI with 1 swap on Uniswap V2 // Trade 1 WETH for DAI with 1 swap on Uniswap V2
// Checks amount out at the end // Fails while transferring the tokenIn to the router due to insufficient approval
uint256 amountIn = 1 ether; uint256 amountIn = 1 ether;
// Approve less than the amountIn
deal(WETH_ADDR, ALICE, amountIn); deal(WETH_ADDR, ALICE, amountIn);
vm.startPrank(ALICE); vm.startPrank(ALICE);
// Approve less than the amountIn
IERC20(WETH_ADDR).approve(address(tychoRouterAddr), amountIn - 1); IERC20(WETH_ADDR).approve(address(tychoRouterAddr), amountIn - 1);
bytes memory protocolData = encodeUniswapV2Swap( bytes memory protocolData = encodeUniswapV2Swap(
@@ -494,7 +494,7 @@ contract TychoRouterTest is TychoRouterTestSetup {
vm.stopPrank(); vm.stopPrank();
} }
function testSwapCheckedFailure() public { function testSwapCheckedNegativeSlippageFailure() public {
// Trade 1 WETH for DAI with 1 swap on Uniswap V2 // Trade 1 WETH for DAI with 1 swap on Uniswap V2
// Does permit2 token approval and transfer // Does permit2 token approval and transfer
// Checks amount out at the end and fails // Checks amount out at the end and fails