From 530c86dbf3db06c155ea57dacdcf56e175eee88e Mon Sep 17 00:00:00 2001 From: Diana Carvalho Date: Fri, 21 Feb 2025 11:20:53 +0000 Subject: [PATCH 1/2] chore: Remove LICENSE We are working on a special license format for tycho-execution. For now we can't have any license --- don't change below this line --- ENG-4260 Took 51 seconds Took 31 minutes Took 59 seconds --- LICENSE | 21 --------------------- 1 file changed, 21 deletions(-) delete mode 100644 LICENSE diff --git a/LICENSE b/LICENSE deleted file mode 100644 index f2b5457..0000000 --- a/LICENSE +++ /dev/null @@ -1,21 +0,0 @@ -MIT License - -Copyright (c) 2025 PropellerHeads - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. From 0ba5d02268e42e10ab9a7d4390eb87dfd7099f07 Mon Sep 17 00:00:00 2001 From: Diana Carvalho Date: Fri, 21 Feb 2025 11:37:06 +0000 Subject: [PATCH 2/2] feat: Use openzepplin's sendValue instead of send for ETH transfers --- don't change below this line --- ENG-4260 Took 7 minutes --- foundry/src/TychoRouter.sol | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/foundry/src/TychoRouter.sol b/foundry/src/TychoRouter.sol index 41ddde3..b009233 100644 --- a/foundry/src/TychoRouter.sol +++ b/foundry/src/TychoRouter.sol @@ -15,7 +15,6 @@ import "./Dispatcher.sol"; import {LibSwap} from "../lib/LibSwap.sol"; import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol"; -error TychoRouter__WithdrawalFailed(); error TychoRouter__AddressZero(); error TychoRouter__EmptySwaps(); error TychoRouter__NegativeSlippage(uint256 amount, uint256 minAmount); @@ -408,9 +407,7 @@ contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard { uint256 amount = address(this).balance; if (amount > 0) { emit Withdrawal(address(0), amount, receiver); - // slither-disable-next-line arbitrary-send-eth - bool success = payable(receiver).send(amount); - if (!success) revert TychoRouter__WithdrawalFailed(); + Address.sendValue(payable(receiver), amount); } }