Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Remove transfer flag from curve + balancer

Browse Source 
we will never perform a manual transfer into these protocols, as they require the tokens to be in the router contract in order to perform a transferFrom.
This commit is contained in:
TAMARA LIPOWSKI
2025-05-15 09:15:32 -04:00
parent b0b98c5e5d
commit 4a0533b8ea
6 changed files with 29 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/encoding/evm/swap_encoder/swap_encoders.rs
View File

@@ -284,7 +284,6 @@ impl SwapEncoder for BalancerV2SwapEncoder {
component_id,
bytes_to_address(&encoding_context.receiver)?,
approval_needed,
encoding_context.transfer,
);
Ok(args.abi_encode_packed())
}
@@ -578,7 +577,6 @@ impl SwapEncoder for CurveSwapEncoder {
i.to_be_bytes::<1>(),
j.to_be_bytes::<1>(),
approval_needed,
encoding_context.transfer,
bytes_to_address(&encoding_context.receiver)?,
);
@@ -827,9 +825,7 @@ mod tests {
// receiver
"1d96f2f6bef1202e4ce1ff6dad0c2cb002861d3e",
// approval needed
"01",
// transfer false
"00",
"01"
))
);
write_calldata_to_file("test_encode_balancer_v2", hex_swap.as_str());
@@ -1408,8 +1404,6 @@ mod tests {
"01",
// approval needed
"01",
// transfer false
"00",
// receiver,
"1d96f2f6bef1202e4ce1ff6dad0c2cb002861d3e"
))
@@ -1479,8 +1473,6 @@ mod tests {
"00",
// approval needed
"01",
// transfer false
"00",
// receiver
"1d96f2f6bef1202e4ce1ff6dad0c2cb002861d3e"
))
@@ -1560,8 +1552,6 @@ mod tests {
"01",
// approval needed
"01",
// transfer false
"00",
// receiver
"1d96f2f6bef1202e4ce1ff6dad0c2cb002861d3e"
))