Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Remove transfer flag from curve + balancer

Browse Source 
we will never perform a manual transfer into these protocols, as they require the tokens to be in the router contract in order to perform a transferFrom.
This commit is contained in:
TAMARA LIPOWSKI
2025-05-15 09:15:32 -04:00
parent b0b98c5e5d
commit 4a0533b8ea
6 changed files with 29 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
foundry/test/executors/BalancerV2Executor.t.sol
View File

@@ -14,8 +14,7 @@ contract BalancerV2ExecutorExposed is BalancerV2Executor {
IERC20 tokenOut,
bytes32 poolId,
address receiver,
bool needsApproval,
bool transferNeeded
bool needsApproval
)
{
return _decodeData(data);
@@ -39,7 +38,7 @@ contract BalancerV2ExecutorTest is Constants, TestUtils {
function testDecodeParams() public view {
bytes memory params = abi.encodePacked(
WETH_ADDR, BAL_ADDR, WETH_BAL_POOL_ID, address(2), true, false
WETH_ADDR, BAL_ADDR, WETH_BAL_POOL_ID, address(2), true
);
(
@@ -47,8 +46,7 @@ contract BalancerV2ExecutorTest is Constants, TestUtils {
IERC20 tokenOut,
bytes32 poolId,
address receiver,
bool needsApproval,
bool transferNeeded
bool needsApproval
) = balancerV2Exposed.decodeParams(params);
assertEq(address(tokenIn), WETH_ADDR);
@@ -68,9 +66,8 @@ contract BalancerV2ExecutorTest is Constants, TestUtils {
function testSwap() public {
uint256 amountIn = 10 ** 18;
bytes memory protocolData = abi.encodePacked(
WETH_ADDR, BAL_ADDR, WETH_BAL_POOL_ID, BOB, true, false
);
bytes memory protocolData =
abi.encodePacked(WETH_ADDR, BAL_ADDR, WETH_BAL_POOL_ID, BOB, true);
deal(WETH_ADDR, address(balancerV2Exposed), amountIn);
uint256 balanceBefore = BAL.balanceOf(BOB);
@@ -90,8 +87,7 @@ contract BalancerV2ExecutorTest is Constants, TestUtils {
IERC20 tokenOut,
bytes32 poolId,
address receiver,
bool needsApproval,
bool transferNeeded
bool needsApproval
) = balancerV2Exposed.decodeParams(protocolData);
assertEq(address(tokenIn), WETH_ADDR);