fix: Rename constants and update docstrings for clarity

--- don't change below this line ---
ENG-4314 Took 44 minutes


Took 9 seconds
This commit is contained in:
Diana Carvalho
2025-04-17 15:51:01 +01:00
parent 8aa5b08b41
commit 244b7d3482
3 changed files with 32 additions and 35 deletions

View File

@@ -1,7 +1,7 @@
use tycho_common::Bytes;
use crate::encoding::{
evm::constants::IN_TRANSFER_OPTIMIZABLE_PROTOCOLS,
evm::constants::IN_TRANSFER_REQUIRED_PROTOCOLS,
models::{Swap, TransferType},
};
@@ -19,8 +19,8 @@ pub trait TransferOptimization {
wrap: bool,
in_between_swap_optimization: bool,
) -> TransferType {
let in_transfer_optimizable: bool =
IN_TRANSFER_OPTIMIZABLE_PROTOCOLS.contains(&swap.component.protocol_system.as_str());
let in_transfer_required: bool =
IN_TRANSFER_REQUIRED_PROTOCOLS.contains(&swap.component.protocol_system.as_str());
let is_first_swap = swap.token_in == given_token;
@@ -31,7 +31,7 @@ pub trait TransferOptimization {
// Wrapping already happened in the router so we can just use a normal transfer.
TransferType::TransferToProtocol
} else if is_first_swap {
if in_transfer_optimizable {
if in_transfer_required {
if permit2 {
// Transfer from swapper to pool using permit2.
TransferType::TransferPermit2ToProtocol
@@ -47,7 +47,7 @@ pub trait TransferOptimization {
TransferType::TransferFromToRouter
}
// all other swaps
} else if !in_transfer_optimizable || in_between_swap_optimization {
} else if !in_transfer_required || in_between_swap_optimization {
// funds should already be in the router or in the next pool
TransferType::None
} else {