feat: Emit event when removing executor
- This is not so relevant for security, but it would sabotage our performance if an executor was wrongly removed, so it's worth it to know every time this happens.
This commit is contained in:
@@ -22,6 +22,7 @@ contract SwapExecutionDispatcher {
|
||||
mapping(address => bool) public swapExecutors;
|
||||
|
||||
event ExecutorSet(address indexed executor);
|
||||
event ExecutorRemoved(address indexed executor);
|
||||
|
||||
/**
|
||||
* @dev Adds or replaces an approved swap executor contract address if it is a
|
||||
@@ -42,6 +43,7 @@ contract SwapExecutionDispatcher {
|
||||
*/
|
||||
function _removeSwapExecutor(address target) internal {
|
||||
delete swapExecutors[target];
|
||||
emit ExecutorRemoved(target);
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -33,6 +33,7 @@ contract SwapExecutionDispatcherTest is Constants {
|
||||
SwapExecutionDispatcherExposed dispatcherExposed;
|
||||
|
||||
event ExecutorSet(address indexed executor);
|
||||
event ExecutorRemoved(address indexed executor);
|
||||
|
||||
function setUp() public {
|
||||
uint256 forkBlock = 20673900;
|
||||
@@ -52,6 +53,9 @@ contract SwapExecutionDispatcherTest is Constants {
|
||||
|
||||
function testRemoveExecutor() public {
|
||||
dispatcherExposed.exposedSetSwapExecutor(DUMMY);
|
||||
vm.expectEmit();
|
||||
// Define the event we expect to be emitted at the next step
|
||||
emit ExecutorRemoved(DUMMY);
|
||||
dispatcherExposed.exposedRemoveSwapExecutor(DUMMY);
|
||||
assert(dispatcherExposed.swapExecutors(DUMMY) == false);
|
||||
}
|
||||
|
||||
@@ -14,7 +14,6 @@ contract TychoRouterTest is TychoRouterTestSetup {
|
||||
bytes32 public constant FUND_RESCUER_ROLE =
|
||||
0x912e45d663a6f4cc1d0491d8f046e06c616f40352565ea1cdb86a0e1aaefa41b;
|
||||
|
||||
event ExecutorSet(address indexed executor);
|
||||
event CallbackVerifierSet(address indexed callbackVerifier);
|
||||
event Withdrawal(
|
||||
address indexed token, uint256 amount, address indexed receiver
|
||||
|
||||
Reference in New Issue
Block a user