Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Improve docstrings and decode bools always the same way

Browse Source 
Took 26 minutes
This commit is contained in:
Diana Carvalho
2025-05-15 18:01:27 +01:00
parent 7fd9f611e5
commit 0b5233ead4
4 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
foundry/src/executors/BalancerV2Executor.sol
View File

@@ -78,6 +78,6 @@ contract BalancerV2Executor is IExecutor {
tokenOut = IERC20(address(bytes20(data[20:40])));
poolId = bytes32(data[40:72]);
receiver = address(bytes20(data[72:92]));
approvalNeeded = uint8(data[92]) > 0;
approvalNeeded = data[92] != 0;
}
}

4
foundry/src/executors/UniswapV3Executor.sol
View File

@@ -159,8 +159,8 @@ contract UniswapV3Executor is IExecutor, ICallback, OneTransferFromOnly {
receiver = address(bytes20(data[43:63]));
target = address(bytes20(data[63:83]));
zeroForOne = uint8(data[83]) > 0;
transferFromNeeded = uint8(data[84]) > 0;
transferNeeded = uint8(data[85]) > 0;
transferFromNeeded = data[84] != 0;
transferNeeded = data[85] != 0;
}
function _makeV3CallbackData(

6
foundry/src/executors/UniswapV4Executor.sol
View File

@@ -155,9 +155,9 @@ contract UniswapV4Executor is
tokenIn = address(bytes20(data[0:20]));
tokenOut = address(bytes20(data[20:40]));
zeroForOne = (data[40] != 0);
transferFromNeeded = (data[41] != 0);
transferNeeded = (data[42] != 0);
zeroForOne = data[40] != 0;
transferFromNeeded = data[41] != 0;
transferNeeded = data[42] != 0;
receiver = address(bytes20(data[43:63]));
uint256 poolsLength = (data.length - 63) / 26; // 26 bytes per pool object