Liquidity.Party/tycho-execution
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Make naming consistent: transfer_needed, approval_needed, etc

Browse Source 
Took 46 minutes
This commit is contained in:
Diana Carvalho
2025-05-15 14:52:43 +01:00
parent 4a0533b8ea
commit 09ff7691f8
9 changed files with 117 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
foundry/src/executors/BalancerV2Executor.sol
View File

@@ -29,10 +29,10 @@ contract BalancerV2Executor is IExecutor {
IERC20 tokenOut,
bytes32 poolId,
address receiver,
bool needsApproval
bool approvalNeeded
) = _decodeData(data);
if (needsApproval) {
if (approvalNeeded) {
// slither-disable-next-line unused-return
tokenIn.forceApprove(VAULT, type(uint256).max);
}
@@ -67,7 +67,7 @@ contract BalancerV2Executor is IExecutor {
IERC20 tokenOut,
bytes32 poolId,
address receiver,
bool needsApproval
bool approvalNeeded
)
{
if (data.length != 93) {
@@ -78,6 +78,6 @@ contract BalancerV2Executor is IExecutor {
tokenOut = IERC20(address(bytes20(data[20:40])));
poolId = bytes32(data[40:72]);
receiver = address(bytes20(data[72:92]));
needsApproval = uint8(data[92]) > 0;
approvalNeeded = uint8(data[92]) > 0;
}
}

8
foundry/src/executors/CurveExecutor.sol
View File

@@ -61,11 +61,11 @@ contract CurveExecutor is IExecutor {
uint8 poolType,
int128 i,
int128 j,
bool tokenApprovalNeeded,
bool approvalNeeded,
address receiver
) = _decodeData(data);
if (tokenApprovalNeeded && tokenIn != nativeToken) {
if (approvalNeeded && tokenIn != nativeToken) {
// slither-disable-next-line unused-return
IERC20(tokenIn).forceApprove(address(pool), type(uint256).max);
}
@@ -119,7 +119,7 @@ contract CurveExecutor is IExecutor {
uint8 poolType,
int128 i,
int128 j,
bool tokenApprovalNeeded,
bool approvalNeeded,
address receiver
)
{
@@ -129,7 +129,7 @@ contract CurveExecutor is IExecutor {
poolType = uint8(data[60]);
i = int128(uint128(uint8(data[61])));
j = int128(uint128(uint8(data[62])));
tokenApprovalNeeded = data[63] != 0;
approvalNeeded = data[63] != 0;
receiver = address(bytes20(data[64:84]));
}