Liquidity.Party/lmsr-amm
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

flashLoan gas test

Browse Source
This commit is contained in:
tim
2025-10-07 15:57:04 -04:00
parent 457385e692
commit 12957aaa51
3 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/PartyPool.sol
View File

@@ -411,13 +411,13 @@ contract PartyPool is PartyPoolBase, ERC20External, IPartyPool {
{ {
IERC20 token = IERC20(tokenAddr); IERC20 token = IERC20(tokenAddr);
require(amount <= token.balanceOf(address(this))); require(amount <= token.balanceOf(address(this)));
uint256 tokenIndex = tokenAddressToIndexPlusOne[token] - 1;
(uint256 fee, ) = _computeFee(amount, FLASH_FEE_PPM); (uint256 fee, ) = _computeFee(amount, FLASH_FEE_PPM);
// Compute protocol share of flash fee // Compute protocol share of flash fee
if (PROTOCOL_FEE_PPM > 0 && fee > 0) { if (PROTOCOL_FEE_PPM > 0 && fee > 0) {
uint256 protoShare = (fee * PROTOCOL_FEE_PPM) / 1_000_000; // floor uint256 protoShare = (fee * PROTOCOL_FEE_PPM) / 1_000_000; // floor
if (protoShare > 0) { if (protoShare > 0) {
uint256 tokenIndex = tokenAddressToIndexPlusOne[token] - 1;
protocolFeesOwed[tokenIndex] += protoShare; protocolFeesOwed[tokenIndex] += protoShare;
} }
} }
@@ -427,7 +427,6 @@ contract PartyPool is PartyPoolBase, ERC20External, IPartyPool {
require(token.transferFrom(address(receiver), address(this), amount + fee)); require(token.transferFrom(address(receiver), address(this), amount + fee));
// Update cached balance for the borrowed token // Update cached balance for the borrowed token
uint256 tokenIndex = tokenAddressToIndexPlusOne[token] - 1;
uint256 balAfter = token.balanceOf(address(this)); uint256 balAfter = token.balanceOf(address(this));
_recordCachedBalance(tokenIndex, balAfter); _recordCachedBalance(tokenIndex, balAfter);

6
test/GasTest.sol
View File

@@ -34,10 +34,6 @@ contract FlashBorrower is IERC3156FlashBorrower {
payer = _payer; payer = _payer;
} }
function flash(address token, uint256 amount) external {
PartyPool(pool).flashLoan(IERC3156FlashBorrower(address(this)), token, amount, "");
}
function onFlashLoan( function onFlashLoan(
address /*initiator*/, address /*initiator*/,
address token, address token,
@@ -416,7 +412,7 @@ contract GasTest is Test {
// Execute flash loan 10 times to measure gas // Execute flash loan 10 times to measure gas
for (uint256 i = 0; i < 10; i++) { for (uint256 i = 0; i < 10; i++) {
borrower.flash(token, amount); pool2.flashLoan(borrower, token, amount, "");
} }
} }
} }

16
test/PartyPool.t.sol
View File

@@ -37,10 +37,6 @@ contract FlashBorrower is IERC3156FlashBorrower {
payer = _payer; payer = _payer;
} }
function flash(address token, uint256 amount) external {
PartyPool(pool).flashLoan(IERC3156FlashBorrower(address(this)), token, amount, "");
}
function onFlashLoan( function onFlashLoan(
address /*initiator*/, address /*initiator*/,
address token, address token,
@@ -850,7 +846,7 @@ contract PartyPoolTest is Test {
uint256 poolToken0Before = token0.balanceOf(address(pool)); uint256 poolToken0Before = token0.balanceOf(address(pool));
// Execute flash loan // Execute flash loan
borrower.flash(address(token0), amount); pool.flashLoan(borrower, address(token0), amount, "");
// Net change for alice should equal the flash fee (principal is returned during repayment) // Net change for alice should equal the flash fee (principal is returned during repayment)
uint256 fee = (amount * pool.flashFeePpm() + 1_000_000 - 1) / 1_000_000; // ceil fee calculation uint256 fee = (amount * pool.flashFeePpm() + 1_000_000 - 1) / 1_000_000; // ceil fee calculation
@@ -882,7 +878,7 @@ contract PartyPoolTest is Test {
// Execute flash loan - should revert due to insufficient allowance when pool tries to pull repayment // Execute flash loan - should revert due to insufficient allowance when pool tries to pull repayment
vm.expectRevert(); vm.expectRevert();
borrower.flash(address(token0), amount); pool.flashLoan(borrower, address(token0), amount, "");
} }
/// @notice Test flash loan with partial repayment (should revert) /// @notice Test flash loan with partial repayment (should revert)
@@ -897,7 +893,7 @@ contract PartyPoolTest is Test {
// Execute flash loan - should revert due to insufficient allowance when pool tries to pull full repayment // Execute flash loan - should revert due to insufficient allowance when pool tries to pull full repayment
vm.expectRevert(); vm.expectRevert();
borrower.flash(address(token0), amount); pool.flashLoan(borrower, address(token0), amount, "");
} }
/// @notice Test flash loan with principal repayment but no fee (should revert) /// @notice Test flash loan with principal repayment but no fee (should revert)
@@ -913,10 +909,10 @@ contract PartyPoolTest is Test {
// Execute flash loan - should revert due to insufficient allowance if fee > 0 // Execute flash loan - should revert due to insufficient allowance if fee > 0
if (pool.flashFeePpm() > 0) { if (pool.flashFeePpm() > 0) {
vm.expectRevert(); vm.expectRevert();
borrower.flash(address(token0), amount); pool.flashLoan(borrower, address(token0), amount, "");
} else { } else {
// If fee is zero, this should succeed // If fee is zero, this should succeed
borrower.flash(address(token0), amount); pool.flashLoan(borrower, address(token0), amount, "");
} }
} }
@@ -935,7 +931,7 @@ contract PartyPoolTest is Test {
uint256 poolToken0Before = token0.balanceOf(address(pool)); uint256 poolToken0Before = token0.balanceOf(address(pool));
// Execute flash loan // Execute flash loan
borrower.flash(address(token0), amount); pool.flashLoan(borrower, address(token0), amount, "");
// Check balances: net change for alice should equal the fee // Check balances: net change for alice should equal the fee
uint256 fee = (amount * pool.flashFeePpm() + 1_000_000 - 1) / 1_000_000; // ceil fee calculation uint256 fee = (amount * pool.flashFeePpm() + 1_000_000 - 1) / 1_000_000; // ceil fee calculation